chore: bump requests-toolbelt to 1.0.0 fixes #10470

[SimonDR-Boltzmann]

Description of your changes:

Bumps requests-toolbelt from 0.9.1 to 1.0.0 (see #10470)

Checklist:

• The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

[google-oss-prow]

Hi @SimonDR-Boltzmann. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rimolive]

/ok-to-test

[rimolive]

@SimonDR-Boltzmann I believe this is not the only place to upgrade requests-toolbelt. Looking at the entire repo, I see at least 8 other occurrences of that Python package. I'm new to the kfp code, so I'm unsure what the root requirements.txt does in the code, but I can tell you that the ones inside backend/ and sdk/python are the most important ones. And there's the test/kfp-functional-test/requirements.txt file to run the functional tests with that new dependency version.

That being said, ensure that all occurrences of that package are upgraded to 1.1.0 version.

[SimonDR-Boltzmann]

@SimonDR-Boltzmann I believe this is not the only place to upgrade requests-toolbelt. Looking at the entire repo, I see at least 8 other occurrences of that Python package. I'm new to the kfp code, so I'm unsure what the root requirements.txt does in the code, but I can tell you that the ones inside backend/ and sdk/python are the most important ones. And there's the test/kfp-functional-test/requirements.txt file to run the functional tests with that new dependency version.

That being said, ensure that all occurrences of that package are upgraded to 1.1.0 version.

@rimolive You're right, I should have checked. It also seems the 1.1.0 is not on pypi yet, so I've bumped to 1.0.0 instead

[rimolive]

/test kubeflow-pipeline-e2e-test

[SimonDR-Boltzmann]

@rimolive I could use your help debugging these failed tests, I'm not sure what the CancelledErrors mean, and I get a 403 when I click on the experiment/run details links.

[rimolive]

@SimonDR-Boltzmann Just rebase and I believe the new Github Action tests will run.

[google-oss-prow]

@SimonDR-Boltzmann: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
kubeflow-pipeline-upgrade-test	3d7827e	link	false	/test kubeflow-pipeline-upgrade-test
kubeflow-pipeline-e2e-test	3d7827e	link	false	/test kubeflow-pipeline-e2e-test
kfp-kubernetes-execution-tests	3d7827e	link	false	/test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[SimonDR-Boltzmann]

@SimonDR-Boltzmann Just rebase and I believe the new Github Action tests will run.

@rimolive It seems the tests still fail, but I still can't seem to access the relevant logs to see what's going on.

[hbelmiro]

@SimonDR-Boltzmann you can ignore those tests. They are all optional.
We can see it here.

[gregsheremeta]

@SimonDR-Boltzmann please rebase this PR. We've done some test fixes, and maybe everything will just pass now.

[rimolive]

@SimonDR-Boltzmann May I ask to rebase again? We migrated most of these tests to GitHub actions, now we can run propoer tests in your PR

[rimolive]

/rerun-all

[rimolive]

/rerun-all

[rimolive]

/lgtm

cc @HumairAK @gregsheremeta @chensun @zijianjoy

[gregsheremeta]

I don't have experience updating python dependencies yet, but this looks solid to me, and the tests pass.

thanks!

/lgtm

[SimonDR-Boltzmann]

@chensun @zijianjoy could you please review this? thank you in advance

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[rimolive]

/rerun-all

[rimolive]

@SimonDR-Boltzmann There are some failling tests. Can you take a look?

[SimonDR-Boltzmann]

@SimonDR-Boltzmann There are some failling tests. Can you take a look?

@rimolive Apart from the

E       AssertionError: Pipeline components-preprocess ended with incorrect status: FAILED. More info: http://localhost:8888/#/runs/details/c86fcaeb-9963-4272-b6e1-817d8429d381
E       assert 'FAILED' == 'SUCCEEDED'
E         - SUCCEEDED
E         + FAILED

I can't really tell what's the cause of the errors. I'm having some trouble testing locally, could you point me in the right direction?

[gregsheremeta]

I tried to run the tests locally as well (to see if I could help you out) and building images fails for me:

sha256:f326c34ea3fa9c3e2a71ffb6f85986c988a4d0bdc270b28fe3642502426fc125
The push refers to repository [kind-registry:5000/apiserver]
Get "https://kind-registry:5000/v2/": dial tcp: lookup kind-registry: no such host
Failed to build apiserver image.

I might be doing something wrong. It's my first time trying to do this.

Anyone know if we have documentation somewhere for running these e2e kind tests locally?

[diegolovison]

/hold

[diegolovison]

Did you execute the command pip-compile --no-emit-index-url requirements.in to update the requirements.txt?

[SimonDR-Boltzmann]

I should have read the readme better, I updated with pip-compile now.

[diegolovison]

Did you execute pip-compile requirements.in to genereta the requirements.txt?

[SimonDR-Boltzmann]

I tried, but now the requests-toolbelt version is back to 0.10.1 here

[diegolovison]

Double-check the dependency tree and see what library is requesting requests-toolbelt be with 0.10.1

[SimonDR-Boltzmann]

it's kfp(==2.9.0), but I'm not sure how to fix that without releasing and versioning the other change.

[diegolovison]

cc @chensun what we should do in this case?

[diegolovison]

Try the following from project root folder:

pip install sdk/python/

The cd test/kfp-functional-test and execute

pip-compile requirements.in

In this case, we won't need to have a version before your change.

Please let me know if this will work.

[SimonDR-Boltzmann]

it doesn't work, I'm afraid, pip-compile still looks to PyPI it seems. If in requirements.in I replace kfp by ../../sdk/python it does work, but I'm guessing that's not a good solution.

[diegolovison]

@chensun any idea?

[SimonDR-Boltzmann]

@chensun could you take a look?

[rimolive]

@diegolovison @SimonDR-Boltzmann I believe this is because it's installing kfp from pypi repo, which still uses the old library version. What you could try is temporarily test adding the git+ssh entry in requirements.in pointing to your branch and see if pip-compile requirements.in upgrades to 1.0.

cc @gregsheremeta for awareness.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign connor-mccarthy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• sdk/OWNERS
• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hbelmiro]

/rerun-all

[smthngslv]

Hello! Can this be merged?

[diegolovison]

No. We need to fix #10762 (comment)

[SimonDR-Boltzmann]

/rerun-all