Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] <RuntimeClass> Ability to specify spec.runtimeClassName inside Pod pipeline #11084

Open
namirinz opened this issue Aug 7, 2024 · 5 comments

Comments

@namirinz
Copy link

namirinz commented Aug 7, 2024

Feature Area

In my GPU cluster to make a K8s pod able to use GPU is to specify spec.runtimeClassName: nvidia .
(https://kubernetes.io/docs/concepts/containers/runtime-class/#usage)

What feature would you like to see?

Ability to add RuntimeClass Name into the component or task.

Ex.


@container_component
def train_from_csv():
    return dsl.ContainerSpec(
        image="",
        command=["python", "train.py"],
        args=[],
    )

@pipeline(name="complex_pipeline")
def complex_pipeline(kernel: str):
    model = train_from_csv()
    
    ##### HERE ####
    set_runtimeclass_name(task=model, runtimeclass="nvidia")

What is the use case or pain point?

Able to have a component that able to use GPU (ex. Train Model)

Is there a workaround currently?


Love this idea? Give it a 👍.

@namirinz
Copy link
Author

namirinz commented Aug 7, 2024

#8052

@namirinz
Copy link
Author

namirinz commented Aug 7, 2024

/assign @chensun @rimolive

@aybchan
Copy link

aybchan commented Aug 19, 2024

We also ran into this issue with Kubeflow Pipelines on k3s. You can implement a mutating admission controller to apply on-the-fly custom modifications (such as adding a runtimeClassName field) to resource creation requests

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Oct 19, 2024
@rimolive
Copy link
Member

/lifecycle frozen

@google-oss-prow google-oss-prow bot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants