-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Backend + SDK): Update kfp backend and kubernetes sdk to support node affinity #10672
base: master
Are you sure you want to change the base?
Conversation
Hi @cjidboon94. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @cjidboon94! With #10671 already merged, do you think we can unhold this PR? |
@rimolive For sure! |
/unhold |
cc @chensun As the PR author said it's ready to review, can you remove the WIP tag? |
@rimolive Oh, it's not ready yet for review. Sorry, misunderstood what you meant by unhold. What I meant was that I'm going to finish this PR and then will switch it to "Ready for review" |
Hi @cjidboon94, do you have an ETA when you plan to finish the PR? Just to say that @droctothorpe is willing to help. |
Happy to help. This PR may be a helpful reference. |
@droctothorpe Thanks for making some time! Maybe you can get ahead on the @rimolive
I hope to finish up this week, had some life things going on that kept me off track but those are resolved now. |
21c2e28
to
2c03265
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Still requires some work, I think (several more python tests to show different cases), but open to feedback/reviews |
Signed-off-by: Cornelis Boon <cjidboon94@gmail.com>
Signed-off-by: Cornelis Boon <cjidboon94@gmail.com>
Signed-off-by: Cornelis Boon <cjidboon94@gmail.com>
Signed-off-by: Cornelis Boon <cjidboon94@gmail.com>
Signed-off-by: Cornelis Boon <cjidboon94@gmail.com>
432ac7f
to
385ba0d
Compare
Any way we can help with this (and pod affinity)? The changes look OK from here. |
Description of your changes:
This PR adds support for node affinity to the driver and kubernetes_platform SDK.
It is a follow up to #10671 and #10583, which updated the protobuf and Golang stub.
It follows the excellent example set by #10427.
Huge thanks to @Tomcli for paving the way and sharing how to validate things end to end.
Part of #9768 and #9682
Pod (Anti)Affinity will be added in a separate PR
Checklist: