Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Backend + SDK): Update kfp backend and kubernetes sdk to support node affinity #10672

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cjidboon94
Copy link
Contributor

Description of your changes:
This PR adds support for node affinity to the driver and kubernetes_platform SDK.

It is a follow up to #10671 and #10583, which updated the protobuf and Golang stub.

It follows the excellent example set by #10427.

Huge thanks to @Tomcli for paving the way and sharing how to validate things end to end.
Part of #9768 and #9682

Pod (Anti)Affinity will be added in a separate PR

Checklist:

Copy link

Hi @cjidboon94. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rimolive
Copy link
Member

Hi @cjidboon94! With #10671 already merged, do you think we can unhold this PR?

@cjidboon94
Copy link
Contributor Author

Hi @cjidboon94! With #10671 already merged, do you think we can unhold this PR?

@rimolive For sure!

@rimolive
Copy link
Member

/unhold

@rimolive
Copy link
Member

cc @chensun

As the PR author said it's ready to review, can you remove the WIP tag?

@cjidboon94
Copy link
Contributor Author

@rimolive Oh, it's not ready yet for review. Sorry, misunderstood what you meant by unhold. What I meant was that I'm going to finish this PR and then will switch it to "Ready for review"

@rimolive
Copy link
Member

rimolive commented Jun 4, 2024

Hi @cjidboon94, do you have an ETA when you plan to finish the PR? Just to say that @droctothorpe is willing to help.

@droctothorpe
Copy link
Contributor

Happy to help. This PR may be a helpful reference.

@cjidboon94
Copy link
Contributor Author

cjidboon94 commented Jun 5, 2024

@droctothorpe Thanks for making some time! Maybe you can get ahead on the podAffinity and podAntiAffinity as this PR will only focus on nodeAffinity. While pod(anti)Affinity does fall under Affinity, I think they're separate enough that you could already work on it. I expect that we might need to merge some things or have a plan on which PR to merge first.

@rimolive
I believe what's left is:

  • backend tests
  • python sdk implementation
  • python sdk tests

I hope to finish up this week, had some life things going on that kept me off track but those are resolved now.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ironpan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Jun 7, 2024
@cjidboon94 cjidboon94 marked this pull request as ready for review June 10, 2024 18:14
@cjidboon94
Copy link
Contributor Author

Still requires some work, I think (several more python tests to show different cases), but open to feedback/reviews

Signed-off-by: Cornelis Boon <cjidboon94@gmail.com>
Signed-off-by: Cornelis Boon <cjidboon94@gmail.com>
Signed-off-by: Cornelis Boon <cjidboon94@gmail.com>
Signed-off-by: Cornelis Boon <cjidboon94@gmail.com>
Signed-off-by: Cornelis Boon <cjidboon94@gmail.com>
@therc
Copy link

therc commented Aug 14, 2024

Any way we can help with this (and pod affinity)? The changes look OK from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants