Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes_platform): Update kubernetes_platform go package to include EnabledSharedMemory #10703

Conversation

hsteude
Copy link
Contributor

@hsteude hsteude commented Apr 17, 2024

This PR adds a message called EnabledSharedMemory to the kubernetes_executor_config.proto file.

This is motivated by #9893.

In this PR #10704, we add the patches for the backend and the python sdk.

Thanks @JosepSampe for the nice example in #10410
Checklist:

Copy link

Hi @hsteude. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hsteude hsteude changed the title feat(kubernetes_platform): Update kubernetes_platform go package to include EnabledSharedMemory, fixes #9893 feat(kubernetes_platform): Update kubernetes_platform go package to include EnabledSharedMemory Apr 17, 2024
@Tomcli
Copy link
Member

Tomcli commented Apr 17, 2024

/ok-to-test
@hsteude you need to sign the commit to comply with the DCO.

@hsteude hsteude force-pushed the feature/support_shm_in_k8s_plt_go_package branch from 71b2218 to c3e597c Compare April 18, 2024 06:12
@hsteude
Copy link
Contributor Author

hsteude commented Apr 18, 2024

@Tomcli: Thanks for the hint. Done!

Signed-off-by: hsteude <henrik.steude@prokube.ai>
@hsteude hsteude force-pushed the feature/support_shm_in_k8s_plt_go_package branch from c3e597c to 90cf4cd Compare April 18, 2024 07:15
Copy link

google-oss-prow bot commented Apr 18, 2024

@hsteude: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-execution-tests 90cf4cd link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rimolive
Copy link
Member

@hsteude Thank you for your contribution!
/lgtm
cc @chensun

@hsteude
Copy link
Contributor Author

hsteude commented May 7, 2024

@chensun Could you have a look at this PR such that I can finalize #10704? Thanks a lot in advance!

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7c63599 into kubeflow:master May 9, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants