-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes_platform): Update kubernetes_platform go package to include EnabledSharedMemory #10703
feat(kubernetes_platform): Update kubernetes_platform go package to include EnabledSharedMemory #10703
Conversation
Hi @hsteude. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
71b2218
to
c3e597c
Compare
@Tomcli: Thanks for the hint. Done! |
Signed-off-by: hsteude <henrik.steude@prokube.ai>
c3e597c
to
90cf4cd
Compare
@hsteude: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds a message called EnabledSharedMemory to the kubernetes_executor_config.proto file.
This is motivated by #9893.
In this PR #10704, we add the patches for the backend and the python sdk.
Thanks @JosepSampe for the nice example in #10410
Checklist: