Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added support for Python 3.13 to tests #11376

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hbelmiro
Copy link
Contributor

Description of your changes:
This PR adds support for Python 3.13 to tests. This is a follow-up for #11372

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hbelmiro and additionally assign connor-mccarthy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@hbelmiro
Copy link
Contributor Author

hbelmiro commented Nov 14, 2024

@chensun we have several tests failing with Python 3.13. Can you please take a look?
Also, I think we should have all tests using at least the minor and major supported Python versions (3.9 and 3.13).

cc @DharmitD @HumairAK

@chensun
Copy link
Member

chensun commented Nov 14, 2024

@chensun we have several tests failing with Python 3.13. Can you please take a look?

From SDK side, kfp-pipeline-spec is blocking Python 3.13 support. I sent a PR: #11378, PTAL.

Also, I think we should have all tests using at least the minor and major supported Python versions (3.9 and 3.13).

No, I think it would be unnecessary and waste of resource to run all e2e or backend-integration tests with different Python versions. If we think SDK's main role as a YAML generator, as long as the produced YAML file doesn't change across Python versions--the SDK unit test guarantees that--they would work on the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants