Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Adding logic to fetch pipeline name in ArtifactsList #9772

Closed

Conversation

axel7083
Copy link
Contributor

Fixes #9746

Description of your changes:

Here is a small fix for removing the getResourcePropertyViaFallBack inside pages/ArtifactList responsible of getting the pipeline/workspace name from Artifact.

From what I can see when using V2, nor the Artifact and execution hold the Pipeline name, or workspaces.

To work around, I created a function taking called getPipelineNameByArtifact, the only place I could find the pipeline name was in the Context, to get the context I had to:

  • Get Events By Artifact
  • Take the execution id in the event
  • GetContextByExecutionID
  • Getting pipeline-name from context name.

Signed-off-by: STEFANINI Axel (INTERN) <42176370+axel7083@users.noreply.github.com>
Signed-off-by: STEFANINI Axel (INTERN) <42176370+axel7083@users.noreply.github.com>
Signed-off-by: STEFANINI Axel (INTERN) <42176370+axel7083@users.noreply.github.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jlyaoyuli for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @axel7083. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khituras
Copy link

Could someone look at this? It's unfortunate that all the artifacts are put into the [unknown] category.

@zijianjoy
Copy link
Collaborator

/ok-to-test

  • @jlyaoyuli Hello Joe, would you like to take a look at this Artifact list PR?

@google-oss-prow
Copy link

@axel7083: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-frontend-test 0ed084e link true /test kubeflow-pipeline-frontend-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontend] artifacts [unknown] pipeline/workspace
4 participants