-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Adding logic to fetch pipeline name in ArtifactsList #9772
feat(frontend): Adding logic to fetch pipeline name in ArtifactsList #9772
Conversation
Signed-off-by: STEFANINI Axel (INTERN) <42176370+axel7083@users.noreply.github.com>
Signed-off-by: STEFANINI Axel (INTERN) <42176370+axel7083@users.noreply.github.com>
Signed-off-by: STEFANINI Axel (INTERN) <42176370+axel7083@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @axel7083. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Could someone look at this? It's unfortunate that all the artifacts are put into the |
/ok-to-test
|
@axel7083: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes #9746
Description of your changes:
Here is a small fix for removing the
getResourcePropertyViaFallBack
insidepages/ArtifactList
responsible of getting the pipeline/workspace name from Artifact.From what I can see when using V2, nor the Artifact and execution hold the Pipeline name, or workspaces.
To work around, I created a function taking called
getPipelineNameByArtifact
, the only place I could find the pipeline name was in the Context, to get the context I had to: