From 06518287b4b011cfee49084030073de1ef0bf8eb Mon Sep 17 00:00:00 2001 From: 1gtm <1gtm@appscode.com> Date: Sat, 17 Aug 2024 06:44:16 +0000 Subject: [PATCH] Use Go 1.23 Signed-off-by: 1gtm <1gtm@appscode.com> Signed-off-by: Tamal Saha --- .github/workflows/ci.yml | 6 +++--- .github/workflows/release-tracker.yml | 2 +- .github/workflows/release.yml | 2 +- Makefile | 4 ++-- pkg/plan/plan.go | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ecbb2a60..15cbd69c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,13 +16,13 @@ concurrency: jobs: build: name: Build - runs-on: ubuntu-20.04 + runs-on: ubuntu-24.04 steps: - - name: Set up Go 1.22 + - name: Set up Go 1.23 uses: actions/setup-go@v1 with: - go-version: '1.22' + go-version: '1.23' id: go - uses: actions/checkout@v2 diff --git a/.github/workflows/release-tracker.yml b/.github/workflows/release-tracker.yml index 6101621b..43e5cfc5 100644 --- a/.github/workflows/release-tracker.yml +++ b/.github/workflows/release-tracker.yml @@ -11,7 +11,7 @@ concurrency: jobs: build: - runs-on: ubuntu-20.04 + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v1 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2da440b7..4504b77e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -13,7 +13,7 @@ concurrency: jobs: build: name: Build - runs-on: ubuntu-20.04 + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v1 diff --git a/Makefile b/Makefile index 8cfe59a2..5aa26d66 100644 --- a/Makefile +++ b/Makefile @@ -77,9 +77,9 @@ TAG := $(VERSION)_$(OS)_$(ARCH) TAG_PROD := $(TAG) TAG_DBG := $(VERSION)-dbg_$(OS)_$(ARCH) -GO_VERSION ?= 1.22 +GO_VERSION ?= 1.23 BUILD_IMAGE ?= ghcr.io/appscode/golang-dev:$(GO_VERSION) -CHART_TEST_IMAGE ?= quay.io/helmpack/chart-testing:v3.5.1 +CHART_TEST_IMAGE ?= quay.io/helmpack/chart-testing:v3.11.0 OUTBIN = bin/$(BIN)-$(OS)-$(ARCH) ifeq ($(OS),windows) diff --git a/pkg/plan/plan.go b/pkg/plan/plan.go index 93eab613..18eb9a9b 100644 --- a/pkg/plan/plan.go +++ b/pkg/plan/plan.go @@ -224,13 +224,13 @@ func SetDNSRecords(ctx context.Context, edns *api.ExternalDNS) ([]api.DNSRecord, reg, err := createRegistry(cfg, pvdr) if err != nil { - klog.Errorf(err.Error()) + klog.Errorln(err) return nil, err } dnsRecs, err := createAndApplyPlan(ctx, cfg, reg, endpointsSource) if err != nil { - klog.Errorf(err.Error()) + klog.Errorln(err) return nil, err }