71: Fix volume mounting #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yaraskm
commented
Jan 30, 2024
yaraskm
commented
- As outlined in Mounting of custom volumes fails templating #71, trying to add a custom volumeMount will fail Helm templating because the mount will be indented too far by two spaces. This resolves issue.
- As outlined in kubereboot#71, trying to add a custom volumeMount will fail Helm templating because the mount will be indented too far by two spaces. - This was tested locally and resolves the templating issue. Signed-off-by: Matt Yaraskavitch <62650344+yaraskm@users.noreply.github.com>
yaraskm
force-pushed
the
71_fix_volume_mounting
branch
from
40e081f
to
8444423
Compare
ckotzbauer
requested changes
Jan 31, 2024
Signed-off-by: Matt Yaraskavitch <62650344+yaraskm@users.noreply.github.com>
Done! Thanks for the review @ckotzbauer |
ckotzbauer
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.