From 844442321c02dad379cb20a3bf1656d15e11c3e3 Mon Sep 17 00:00:00 2001 From: Matt Yaraskavitch <62650344+yaraskm@users.noreply.github.com> Date: Tue, 30 Jan 2024 17:39:11 -0500 Subject: [PATCH 1/2] 71: Fix volume mounting - As outlined in #71, trying to add a custom volumeMount will fail Helm templating because the mount will be indented too far by two spaces. - This was tested locally and resolves the templating issue. Signed-off-by: Matt Yaraskavitch <62650344+yaraskm@users.noreply.github.com> --- charts/kured/templates/daemonset.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/kured/templates/daemonset.yaml b/charts/kured/templates/daemonset.yaml index 86f7e7a..050aed5 100644 --- a/charts/kured/templates/daemonset.yaml +++ b/charts/kured/templates/daemonset.yaml @@ -206,7 +206,7 @@ spec: readOnly: true {{- end }} {{- if .Values.volumeMounts }} -{{- toYaml .Values.volumeMounts | nindent 12 }} +{{- toYaml .Values.volumeMounts | nindent 10 }} {{- end }} ports: - containerPort: {{ .Values.configuration.metricsPort }} From ff476c5663865522b2af98cde991153ff3c6cb37 Mon Sep 17 00:00:00 2001 From: Matt Yaraskavitch <62650344+yaraskm@users.noreply.github.com> Date: Wed, 31 Jan 2024 12:14:57 -0500 Subject: [PATCH 2/2] Bumped chart version as per PR review Signed-off-by: Matt Yaraskavitch <62650344+yaraskm@users.noreply.github.com> --- charts/kured/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/kured/Chart.yaml b/charts/kured/Chart.yaml index 9cd1117..f8ccecc 100644 --- a/charts/kured/Chart.yaml +++ b/charts/kured/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v1 appVersion: "1.15.0" description: A Helm chart for kured name: kured -version: 5.4.1 +version: 5.4.2 home: https://github.com/kubereboot/kured maintainers: - name: chopf