Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to Fractions #1590

Open
Rekkonnect opened this issue Sep 24, 2024 · 1 comment
Open

Remove dependency to Fractions #1590

Rekkonnect opened this issue Sep 24, 2024 · 1 comment

Comments

@Rekkonnect
Copy link

Only one file requires the usage of Fractions and the implementation relies on it without a clear purpose; the numeric computations can all be worked out easily without relying on fractions. Not to mention other unreasonable usages of BigInteger. The file that uses this package is this. Additionally, the package is explicitly referenced in two other projects without a real usage.

This is a leaking package reference that serves no purpose in most applications, and opinionates the usage of a library that has poor performance for real-life implementations using numeric fractions. Minimizing package references is very helpful for consumers to reduce build times and package cache sizes.

@tg123
Copy link
Member

tg123 commented Sep 27, 2024

agree with minimizing dependencies
could you please send pr to remove it, i believe there are still many math related operations need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants