Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sidecars versions #574

Closed
wants to merge 6 commits into from
Closed

Update sidecars versions #574

wants to merge 6 commits into from

Conversation

coulof
Copy link
Contributor

@coulof coulof commented Sep 26, 2023

Bump sidecars versions for kubernetes v1.28 and remove unsupported versions

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: coulof
Once this PR has been reviewed and has the lgtm label, please assign lpabon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2023
@coulof
Copy link
Contributor Author

coulof commented Sep 26, 2023

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 26, 2023
xing-yang
xing-yang reviewed Sep 27, 2023
View reviewed changes
book/src/external-attacher.md Outdated Show resolved Hide resolved
book/src/external-provisioner.md Show resolved Hide resolved
book/src/external-provisioner.md Outdated Show resolved Hide resolved
book/src/external-provisioner.md Outdated Show resolved Hide resolved
book/src/external-snapshotter.md Outdated Show resolved Hide resolved
book/src/external-snapshotter.md Outdated Show resolved Hide resolved
book/src/kubernetes-changelog.md Show resolved Hide resolved
book/src/kubernetes-changelog.md Show resolved Hide resolved
xing-yang
xing-yang reviewed Sep 27, 2023
View reviewed changes
book/src/node-driver-registrar.md Outdated Show resolved Hide resolved
book/src/snapshot-controller.md Outdated Show resolved Hide resolved
book/src/snapshot-controller.md Outdated Show resolved Hide resolved
book/src/snapshot-validation-webhook.md Outdated Show resolved Hide resolved
book/src/snapshot-validation-webhook.md Outdated Show resolved Hide resolved
xing-yang
xing-yang reviewed Sep 28, 2023
View reviewed changes
book/src/kubernetes-changelog.md Outdated
### Features

* Beta
* [StatefulSet PVC Auto-Deletion](https://kubernetes.io/blog/2023/05/04/kubernetes-1-27-statefulset-pvc-auto-deletion-beta/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this one. This is a sig-apps project, also no changes in CSI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This is still in the PR.

book/src/kubernetes-changelog.md Show resolved Hide resolved
@xing-yang
Copy link
Contributor

Can you squash your commits?

xing-yang
xing-yang reviewed Oct 2, 2023
View reviewed changes
book/src/kubernetes-changelog.md Outdated
* [Automatic retroactive assignment of a default StorageClass](https://kubernetes.io/blog/2023/08/18/retroactive-default-storage-class-ga/)
* [Non-graceful node shutdown](https://kubernetes.io/blog/2023/08/16/kubernetes-1-28-non-graceful-node-shutdown-ga/)
* Alpha
* [PersistentVolume last phase transition time](https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3762-persistent-volume-last-phase-transition-time/README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for going back and forth on this. We discussed this at CSI implementation meeting. Since some of these features do not require any CSI driver changes, it is confusing to add them in this doc. Can you please remove the following?

  • Automatic retroactive assignment of a default StorageClass
  • Non-graceful node shutdown
  • PersistentVolume last phase transition time

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you submit your commit? You marked this as resolved but these features are still here in the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I screwed up my rebase...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that mess. Do you want me to create a new PR ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

xing-yang
xing-yang reviewed Oct 2, 2023
View reviewed changes
book/src/kubernetes-changelog.md
* Beta
* [StatefulSet PVC Auto-Deletion](https://kubernetes.io/blog/2023/05/04/kubernetes-1-27-statefulset-pvc-auto-deletion-beta/)
* [Robust VolumeManager reconstruction after kubelet restart](https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3756-volume-reconstruction)
* [ReadWriteOncePod Access mode](https://kubernetes.io/blog/2023/04/20/read-write-once-pod-access-mode-beta/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove these:

  • StatefulSet PVC Auto-Deletion
  • Robust VolumeManager reconstruction after kubelet restart

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This is still in the PR.

@coulof
Copy link
Contributor Author

coulof commented Oct 3, 2023

Can you squash your commits?

For some reason, my branch is a bit ugly and I have a hard time rebasing it cleanly.
Can't we squash and merge directly from the Github portal ?

@xing-yang
Copy link
Contributor

For some reason, my branch is a bit ugly and I have a hard time rebasing it cleanly.
Can't we squash and merge directly from the Github portal ?

I don't think I can squash it for you.

@coulof coulof closed this Oct 9, 2023
@coulof
Copy link
Contributor Author

coulof commented Oct 9, 2023

Closed and replaced by #575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coulof @k8s-ci-robot @xing-yang