fix: ensure Kubernets conformant format for location

[daniel-weisse]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When creating the cloud provider config file, one can specify the location in two (valid for Azure) formats:

• upper case with spaces, e.g. "East US"
• lower case with no spaces, e.g. "eastus"

The driver (as well as other applications making use of the config) will accept and work with both formats.
An issue only arises if nodes in the cluster are created in specific availability zones, e.g. "East US 2":

The topology key (topology.disk.csi.azure.com/zone) of the node will always be set to non zone.

The CreateVolume rpc of the controller server will be unable to schedule the disk in the correct zone, since the azuredisk topology key is set to an empty string.
If one sets up the well-known topology key instead (topology.kubernetes.io/zone) (or updates the azuredisk key manually), creating the disk in the correct zone still fails, because of how the PickAvailabilityZone checks for a valid zone.

This PR aims to fix this issue by ensuring the driver is always set up using the lower case no-space format, even if the config declares the format with spaces.

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: daniel-weisse / name: Daniel Weiße (3746d75)

[k8s-ci-robot]

Welcome @daniel-weisse!

It looks like this is your first PR to kubernetes-sigs/azuredisk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azuredisk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @daniel-weisse. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andyzhangx]

/ok-to-test

[andyzhangx]

/retest

[andyzhangx]

/lgtm
/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, daniel-weisse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

/cherrypick release-1.29

[k8s-infra-cherrypick-robot]

@andyzhangx: new pull request created: #1988

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andyzhangx]

/cherrypick release-1.28

[k8s-infra-cherrypick-robot]

@andyzhangx: new pull request created: #1989

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andyzhangx]

/cherrypick release-1.26

[k8s-infra-cherrypick-robot]

@andyzhangx: new pull request created: #1990

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andyzhangx]

/cherrypick release-1.27

[k8s-infra-cherrypick-robot]

@andyzhangx: new pull request created: #1991

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.