Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.30] fix: unmount volume issue on Windows node #2695

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: unmount volume issue on Windows node, original behavior is just deleting the mounted directory which may lead to mount failure in frequent unmount and mount the same volume on the same node

cherrypick of #2691

I1204 14:39:28.920234    1336 utils.go:105] GRPC call: /csi.v1.Node/NodeUnpublishVolume
I1204 14:39:28.920234    1336 utils.go:106] GRPC request: {"target_path":"c:\\var\\lib\\kubelet\\pods\\d17b945a-2f91-4bfc-b5c9-28e886c86525\\volumes\\kubernetes.io~csi\\pvc-6afee86b-e9b9-4e63-a8a0-d49b887fd682\\mount","volume_id":"/subscriptions/b9d2281e-dcd5-4dfd-9a97-0d50377cdf76/resourceGroups/MC_andy-aks129_andy-aks129_eastus2/providers/Microsoft.Compute/disks/pvc-6afee86b-e9b9-4e63-a8a0-d49b887fd682"}
I1204 14:39:28.920916    1336 nodeserver.go:300] NodeUnpublishVolume: unmounting volume /subscriptions/b9d2281e-dcd5-4dfd-9a97-0d50377cdf76/resourceGroups/MC_andy-aks129_andy-aks129_eastus2/providers/Microsoft.Compute/disks/pvc-6afee86b-e9b9-4e63-a8a0-d49b887fd682 on c:\var\lib\kubelet\pods\d17b945a-2f91-4bfc-b5c9-28e886c86525\volumes\kubernetes.io~csi\pvc-6afee86b-e9b9-4e63-a8a0-d49b887fd682\mount
I1204 14:39:28.920916    1336 nodeserver.go:310] NodeUnpublishVolume: unmount volume /subscriptions/b9d2281e-dcd5-4dfd-9a97-0d50377cdf76/resourceGroups/MC_andy-aks129_andy-aks129_eastus2/providers/Microsoft.Compute/disks/pvc-6afee86b-e9b9-4e63-a8a0-d49b887fd682 on c:\var\lib\kubelet\pods\d17b945a-2f91-4bfc-b5c9-28e886c86525\volumes\kubernetes.io~csi\pvc-6afee86b-e9b9-4e63-a8a0-d49b887fd682\mount successfully
I1204 14:39:28.920916    1336 utils.go:112] GRPC response: {}
I1204 14:39:29.034346    1336 utils.go:105] GRPC call: /csi.v1.Node/NodeUnstageVolume
I1204 14:39:29.034346    1336 utils.go:106] GRPC request: {"staging_target_path":"\\var\\lib\\kubelet\\plugins\\kubernetes.io\\csi\\disk.csi.azure.com\\fef91c0445c24e34b58d31008ed7020a6502e7017b09a1b5b7012d4e3d28a1f6\\globalmount","volume_id":"/subscriptions/b9d2281e-dcd5-4dfd-9a97-0d50377cdf76/resourceGroups/MC_andy-aks129_andy-aks129_eastus2/providers/Microsoft.Compute/disks/pvc-6afee86b-e9b9-4e63-a8a0-d49b887fd682"}
I1204 14:39:29.034346    1336 nodeserver.go:201] NodeUnstageVolume: unmounting \var\lib\kubelet\plugins\kubernetes.io\csi\disk.csi.azure.com\fef91c0445c24e34b58d31008ed7020a6502e7017b09a1b5b7012d4e3d28a1f6\globalmount
I1204 14:39:29.035850    1336 safe_mounter_host_process_windows.go:69] Unmounting volume \\?\Volume{6a72717b-3413-4f50-a487-f46516fdb617}\ from \var\lib\kubelet\plugins\kubernetes.io\csi\disk.csi.azure.com\fef91c0445c24e34b58d31008ed7020a6502e7017b09a1b5b7012d4e3d28a1f6\globalmount
I1204 14:39:31.313932    1336 nodeserver.go:205] NodeUnstageVolume: unmount \var\lib\kubelet\plugins\kubernetes.io\csi\disk.csi.azure.com\fef91c0445c24e34b58d31008ed7020a6502e7017b09a1b5b7012d4e3d28a1f6\globalmount successfully
I1204 14:39:31.314177    1336 utils.go:112] GRPC response: {}

Which issue(s) this PR fixes:

Fixes #2690

Requirements:

Special notes for your reviewer:

Release note:

fix: unmount volume issue on Windows node

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2024
@andyzhangx andyzhangx removed the request for review from edreed December 5, 2024 07:34
@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az df1ee69 link true /test pull-azuredisk-csi-driver-external-e2e-single-az

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit a598cd5 into kubernetes-sigs:release-1.30 Dec 5, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants