Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Personal/dabradley/trivy on development #176

Closed
wants to merge 4 commits into from
Closed

Personal/dabradley/trivy on development #176

wants to merge 4 commits into from

Conversation

dabradley
Copy link
Collaborator

What type of PR is this?
/kind test

What this PR does / why we need it:
Run trivy vulnerability scanner on the development branch which is where new development work will be occurring.

dabradley and others added 4 commits August 26, 2024 09:15
@dabradley
Correct and update workflows so we can enable Actions
8d65fd4 
The existing workflows are out of date and insecure.
This change updates the relevant workflows to the
current state of the repository, corrects some issues,
and disables workflows that will be handled through
other means.
@dependabot @dabradley
Bump golang.org/x/net from 0.17.0 to 0.23.0 (kubernetes-sigs#166)
83d2860 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0.
- [Commits](golang/net@v0.17.0...v0.23.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dabradley <dabradley@users.noreply.github.com>
@dabradley
Fix minor workflow issues
32febd7
@dabradley
Run trivy on development branch as well
d99492d
@k8s-ci-robot
Copy link
Contributor

@dabradley: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind test

What this PR does / why we need it:
Run trivy vulnerability scanner on the development branch which is where new development work will be occurring.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dabradley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@coveralls
Copy link

Coverage Status

coverage: 82.552%. remained the same
when pulling d99492d on dabradley:personal/dabradley/trivy-on-development
into 7c93e26 on kubernetes-sigs:main.

@dabradley dabradley requested review from t-mialve and removed request for vinli-cn and joe-atzinger September 9, 2024 13:48
@dabradley dabradley closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-mialve t-mialve Awaiting requested review from t-mialve

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dabradley @k8s-ci-robot @coveralls