-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloud-node-manager for supporting IMDS #231
Conversation
/assign @andyzhangx @nilo19 |
/lgtm |
/hold |
// cloudNodeManagerUserAgent is the userAgent name when starting cloud-node managers. | ||
cloudNodeManagerUserAgent = "cloud-node-manager" | ||
// defaultCloudNodeManagerPort is the default cloud-node manager port. | ||
defaultCloudNodeManagerPort = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it's 0 by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0 means it's disabled by default
func NewIMDSNodeProvider() *IMDSNodeProvider { | ||
az, err := azureprovider.NewCloud(bytes.NewBuffer([]byte(`{ | ||
"useInstanceMetadata": true, | ||
"vmType": "vmss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcoded only for vmss
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, vmss vmType support both VMSS and VMAS nodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add cloud-node-manager for supporting IMDS. Refer kubernetes/enhancements#1158 for the design details.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: