Add support for Spot VMs

[jwmay2012]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds support for GCP Spot VMs, which are distinct from preemptible vms. Spot VMs are newer.
https://cloud.google.com/compute/docs/instances/spot
They no longer have a mandatory 24 hr limit.

Special notes for your reviewer:

Modeled PR after the addition of preemptible vms.

Documentation that specifies details on provisioningModel, SPOT and STANDARD--
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_instance#provisioning_model
https://cloud.google.com/compute/docs/instances/create-use-spot#create

Relevant docs about field logic--

"provisioningModel": "SPOT" in the Compute Engine API

---------------

If the output includes the provisioningModel field set to SPOT, the VM is a Spot VM.

Otherwise, if the output includes the provisioningModel field set to standard or if the output omits the provisioningModel field:
- If the output includes the preemptible field set to true, the VM is a preemptible VM.
- Otherwise, the VM is a standard VM.

TODOs:

• squashed commits
• includes documentation
• adds unit tests
  No tests exist for preemptible vms. This change seems pretty simple and straight forward and doesn't cause any changes unless the new field is used.

Release note:

Add support for Spot VMs. `GCPMachineTemplate.Spec.ProvisioningModel = "Spot"`

[k8s-ci-robot]

Hi @jwmay2012. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name	Link
🔨 Latest commit	9cec971
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/66ffff634de777000802b25c
😎 Deploy Preview	https://deploy-preview-1313--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[salasberryfin]

/ok-to-test

Thanks for working on this @jwmay2012!

[salasberryfin]

Should we also explicitly set the ProvisioningModel to Standard when not null or is it implicitly set by GCP?

[jwmay2012]

I do believe GCP defaults to STANDARD. All documentation seems to be focused around specifying SPOT and otherwise ignoring the field.

I also figured it was lower risk to maintain the existing behavior when the field is not set, allowing the GCP default to continue to be used.

[salasberryfin]

The CAPG book contains a section on using Preemptible VMs (book source files can be found here). Perhaps it makes sense to also document Spot VMs and what happens with each combination of Preemptible + ProvisioningModel, as you specified on type definition. What do you think?

[jwmay2012]

The CAPG book contains a section on using Preemptible VMs (book source files can be found here). Perhaps it makes sense to also document Spot VMs and what happens with each combination of Preemptible + ProvisioningModel, as you specified on type definition. What do you think?

Makes sense. I'll add the specifics of Preemptible + ProvisioningModel to the docs I've already made. I believe Preemptible gets ignored and ProvisioiningModel overrides. This is implicit in the documentation, but I'll confirm first.

[jwmay2012]

Tested combinations of preemptible: true and provisioningModel: Spot. Spot takes priority.

[salasberryfin]

Thanks for working on this @jwmay2012

[cpanato]

/lgtm

/hold for another eye from @richardcase
/assing @richardcase

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, jwmay2012, salasberryfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[richardcase]

Also from my side:

/lgtm

And so lets

/unhold