Merge pull request #2802 from chrischdi/vcsim-disable-logcollector

🌱 e2e: disable log collector for vcsim testmode
kubernetes-sigs · Mar 11, 2024 · 26932c8 · 26932c8
2 parents 6571eb9 + fd25446
commit 26932c8
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/test/e2e/e2e_suite_test.go b/test/e2e/e2e_suite_test.go
@@ -258,7 +258,13 @@ var _ = SynchronizedBeforeSuite(func() []byte {
 	e2eConfig, err = vsphereframework.LoadE2EConfig(ctx, configPath, configOverridesPath, testTarget, testMode)
 	Expect(err).NotTo(HaveOccurred())
 
-	bootstrapClusterProxy = framework.NewClusterProxy("bootstrap", kubeconfigPath, initScheme(), framework.WithMachineLogCollector(vspherelog.MachineLogCollector{}))
+	clusterProxyOptions := []framework.Option{}
+	// vspherelog.MachineLogCollector tries to ssh to the machines to collect logs.
+	// This does not work when using vcsim because there are no real machines running ssh.
+	if testTarget != VCSimTestTarget {
+		clusterProxyOptions = append(clusterProxyOptions, framework.WithMachineLogCollector(vspherelog.MachineLogCollector{}))
+	}
+	bootstrapClusterProxy = framework.NewClusterProxy("bootstrap", kubeconfigPath, initScheme(), clusterProxyOptions...)
 
 	ipClaimLabels := map[string]string{}
 	for _, s := range strings.Split(ipClaimLabelsRaw, ";") {