Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 lint: fix duplicated words via dupword linter #2260

Merged
merged 1 commit into from
Aug 21, 2023
Merged

🌱 lint: fix duplicated words via dupword linter #2260

merged 1 commit into from
Aug 21, 2023

Conversation

MrDXY
Copy link
Contributor

@MrDXY MrDXY commented Aug 21, 2023 •
edited by chrischdi
Loading

What this PR does / why we need it:
Check the duplicate words in the code via linter configuration, and fix it.
Enable dupword check in .golangci.yml configuration file.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2058

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 21, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MrDXY / name: Xinyuan Du (b16216e)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @MrDXY!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @MrDXY. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 21, 2023
@zhanggbj
Copy link
Contributor

/ok-to-test
And please sign the CLA following the guide above.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 21, 2023
chrischdi
chrischdi reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit.

Thanks for picking up this work!

main.go Outdated
@@ -254,7 +254,7 @@ func main() {
addToManager := func(ctx *context.ControllerManagerContext, mgr ctrlmgr.Manager) error {
tracker, err := setupRemoteClusterCacheTracker(ctx, mgr)
if err != nil {
return perrors.Wrapf(err, "unable to create remote cluster tracker tracker")
return perrors.Wrapf(err, "unable to create remote cluster tracker")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return perrors.Wrapf(err, "unable to create remote cluster tracker")
return perrors.Wrapf(err, "unable to create remote cluster cache tracker")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2023
chrischdi
chrischdi reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dfe55c0145c65861da670458629017feabadb1d1

@chrischdi chrischdi mentioned this pull request Aug 21, 2023
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@chrischdi
Copy link
Member

/ok-to-test

@MrDXY
Copy link
Contributor Author

MrDXY commented Aug 21, 2023

I apologize for any inconvenience. I've made several adjustments after your comment due to test failures attributed to verify-gen at Makefile. To elaborate, the problem arises from a diff inconsistency in the config/default/crd/bases/infrastructure.cluster.x-k8s.io_vspherevms.yaml file compared to the automatically generated CRD files. Consequently, I've modified the CRD file in our source code to ensure consistency.

@chrischdi
Copy link
Member

I apologize for any inconvenience. I've made several adjustments after your comment due to test failures attributed to verify-gen at Makefile. To elaborate, the problem arises from a diff inconsistency in the config/default/crd/bases/infrastructure.cluster.x-k8s.io_vspherevms.yaml file compared to the automatically generated CRD files. Consequently, I've modified the CRD file in our source code to ensure consistency.

I hope you did not do this manually :-) that's what is done via make generate-manifests.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ad163fc0ec062f5efc9082a98a4e7bacb2173bed

@sbueringer
Copy link
Member

I apologize for any inconvenience.

No worries :).

Thank you and welcome :)

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit f664bcc into kubernetes-sigs:main Aug 21, 2023
5 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxRink MaxRink Awaiting requested review from MaxRink

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@MrDXY @k8s-ci-robot @zhanggbj @chrischdi @sbueringer