🌱 Add finalizer for VSphereClusterIdentity #2322
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
killianmuldoon
force-pushed
the
pr-add-vsphereclusteridentity-finalizer
branch
from
5f25d90
to
464f3ca
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-add-vsphereclusteridentity-finalizer
branch
from
464f3ca
to
af4c671
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2322 +/- ##
=======================================
Coverage ? 50.19%
=======================================
Files ? 87
Lines ? 8041
Branches ? 0
=======================================
Hits ? 4036
Misses ? 3678
Partials ? 327 ☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e0992b4e4e45fe2e9a4c810abee76f5236ddc526
|
|
/approve Thank you!! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@killianmuldoon Bug fix => cherry-pick back was the idea, right? |
|
/cherry-pick release-1.8 |
|
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.7 |
|
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@killianmuldoon: new pull request created: #2336 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@killianmuldoon: new pull request created: #2337 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add a finalizer to ensure the cleanup for this type completes.