-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add codecov #2328
🌱 Add codecov #2328
Conversation
/hold |
39163ff
to
0c940e9
Compare
@@ -0,0 +1,12 @@ | |||
coverage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation: https://docs.codecov.com/docs/commit-status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 1% is fine given we use informational
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2328 +/- ##
=======================================
Coverage ? 50.29%
=======================================
Files ? 87
Lines ? 8028
Branches ? 0
=======================================
Hits ? 4038
Misses ? 3664
Partials ? 326 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Stefan Büringer buringerst@vmware.com
0c940e9
to
04d22ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Happy to merge this and see how happy we are with the noise over time.
LGTM label has been added. Git tree hash: 00ca5c920bf8d4c45dccbed17e85a9e4cf154855
|
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Add codecov to keep an overview over our test coverage
(mostly copied from CAPZ)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #2308