🌱 Introduce MODE and TARGET for E2E tests #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2673 +/- ##
==========================================
+ Coverage 64.62% 64.68% +0.05%
==========================================
Files 118 118
Lines 8580 8593 +13
==========================================
+ Hits 5545 5558 +13
- Misses 2602 2604 +2
+ Partials 433 431 -2 ☔ View full report in Codecov by Sentry. |
fabriziopandini
force-pushed
the
introduce-test-mode-and-target
branch
from
18fa5e0
to
418c0b2
Compare
sbueringer
reviewed
Jan 29, 2024
chrischdi
reviewed
Jan 30, 2024
|
fabriziopandini
force-pushed
the
introduce-test-mode-and-target
branch
from
a93168d
to
2359200
Compare
sbueringer
reviewed
Jan 31, 2024
|
@sbueringer thanks for the feedback, all addressed! |
|
/test pull-cluster-api-provider-vsphere-test-main |
chrischdi
reviewed
Jan 31, 2024
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 24870b19eb3dbc799c17e6c202534fe8fac0a5ae
|
k8s-ci-robot
added
the
needs-rebase
fabriziopandini
force-pushed
the
introduce-test-mode-and-target
branch
from
af893db
to
b2b88fe
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
sbueringer
reviewed
Jan 31, 2024
fabriziopandini
force-pushed
the
introduce-test-mode-and-target
branch
from
b2b88fe
to
3b68b3d
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1ed2f4d7581cf63cf20266e2d7a3a2f850c34d65
|
|
Thx! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this PR we introduce the concept of MODE (legacy, supervisor) and TARGET (VMC, BYO vCenter, vcsim) for E2E tests.
This will enable to have tests for supervisors and tests for the vcsim server in follow up prs.
However, it gives also an immediate benefit, because it allows simplifying how the test when using BYO vCenter (previously called dev) by dropping most of the duplicated E2E config file.