Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 vspherevm: ensure that the cache gets updated when patching .status.taskRef #2677

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

A vSphereVM could reconcile again with using an outdated object from the cache.

In case of a VSphereVM which get's deleted this could lead to triggering a task to destroy the VM twice. While the second one would fail after some timeout.

Did hit this issue at https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-vsphere/2594/pull-cluster-api-provider-vsphere-e2e-main/1752293260056858624

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2024
@chrischdi
Copy link
Member Author

/assign sbueringer

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (036fb05) 64.70% compared to head (22bb16e) 64.66%.
Report is 5 commits behind head on main.

Files Patch % Lines
controllers/vspherevm_controller.go 10.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2677      +/-   ##
==========================================
- Coverage   64.70%   64.66%   -0.04%     
==========================================
  Files         118      118              
  Lines        8580     8593      +13     
==========================================
+ Hits         5552     5557       +5     
- Misses       2597     2604       +7     
- Partials      431      432       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischdi chrischdi force-pushed the pr-fix-vspherevm-taskref-patch branch from 9c084ed to b1e7673 Compare January 30, 2024 15:35
@sbueringer
Copy link
Member

/test pull-cluster-api-provider-vsphere-e2e-main

controllers/vspherevm_controller.go Outdated Show resolved Hide resolved
controllers/vspherevm_controller.go Show resolved Hide resolved
controllers/vspherevm_controller.go Outdated Show resolved Hide resolved
@chrischdi chrischdi force-pushed the pr-fix-vspherevm-taskref-patch branch from b1e7673 to 22bb16e Compare January 31, 2024 11:00
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-main

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7993113a00192c54ba542f6b1ca58deac309866b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@sbueringer
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1abcf7c into kubernetes-sigs:main Jan 31, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Jan 31, 2024
@chrischdi
Copy link
Member Author

/cherry-pick release-1.9

@chrischdi chrischdi deleted the pr-fix-vspherevm-taskref-patch branch January 31, 2024 18:59
@k8s-infra-cherrypick-robot

@chrischdi: new pull request created: #2680

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants