Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.9] 🌱 Add conformance and upgrade e2e tests #2679

Merged
merged 2 commits into from
Feb 1, 2024
Merged

[release-1.9] 🌱 Add conformance and upgrade e2e tests #2679

merged 2 commits into from
Feb 1, 2024

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:
Manual cherry-pick of #2594

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@sbueringer
Add conformance test with K8S ci latest
fc10f3d 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Jan 31, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2024
@sbueringer sbueringer changed the title 🌱 Add conformance and upgrade e2e tests [release-1.9] 🌱 Add conformance and upgrade e2e tests Jan 31, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2024
@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-blocking-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-conformance-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-release-1-9
  • /test pull-cluster-api-provider-vsphere-test-integration-release-1-9
  • /test pull-cluster-api-provider-vsphere-test-release-1-9
  • /test pull-cluster-api-provider-vsphere-verify-release-1-9

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-release-1-9

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-release-1-9
  • pull-cluster-api-provider-vsphere-e2e-blocking-release-1-9
  • pull-cluster-api-provider-vsphere-test-integration-release-1-9
  • pull-cluster-api-provider-vsphere-test-release-1-9
  • pull-cluster-api-provider-vsphere-verify-release-1-9

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-conformance-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-release-1-9

fabriziopandini
fabriziopandini reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b690a74f93c4735e47992b82261326fc1924c1a

@sbueringer sbueringer force-pushed the pr-add-conformance-latest-ci-test-1.9 branch from aeeb2ac to ce33c72 Compare January 31, 2024 15:54
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@sbueringer
Copy link
Member Author

Sorry missed a bit of gofmt

@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-conformance-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-release-1-9

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb7c187) 64.59% compared to head (1895c68) 64.62%.
Report is 3 commits behind head on release-1.9.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.9    #2679      +/-   ##
===============================================
+ Coverage        64.59%   64.62%   +0.03%     
===============================================
  Files              118      118              
  Lines             8580     8580              
===============================================
+ Hits              5542     5545       +3     
+ Misses            2603     2602       -1     
+ Partials           435      433       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischdi
Copy link
Member

failure is on a conformance test 👍

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8c37e3f662982d2d763c30ca9956a4d766067d2a

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@sbueringer
Copy link
Member Author

Let's give this another try

I don't think I broke it :D

/test pull-cluster-api-provider-vsphere-e2e-release-1-9

@sbueringer
Copy link
Member Author

But let's see maybe I broke the image patch somehow

@sbueringer
Copy link
Member Author

The 1.27.3 & Ubuntu 22 image wasn't available in VMC. I'll fix it and rerun

@sbueringer
Add conformance and upgrade e2e tests
1895c68 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-add-conformance-latest-ci-test-1.9 branch from ce33c72 to 1895c68 Compare January 31, 2024 18:53
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-conformance-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-release-1-9

@chrischdi
Copy link
Member

Nice finding

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 031acb770d0619352d57c0c4d3438be555fad4da

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

/override pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-release-1-9

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-release-1-9

In response to this:

/override pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-release-1-9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit cc68f9d into kubernetes-sigs:release-1.9 Feb 1, 2024
21 checks passed
@sbueringer sbueringer deleted the pr-add-conformance-latest-ci-test-1.9 branch February 1, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gab-satchi gab-satchi Awaiting requested review from gab-satchi

@yastij yastij Awaiting requested review from yastij

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @k8s-ci-robot @chrischdi @fabriziopandini