-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ enables explicit disabling of cluster module #3224
base: main
Are you sure you want to change the base?
✨ enables explicit disabling of cluster module #3224
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @RenilRaj-BR. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@@ -59,6 +59,12 @@ type VSphereClusterSpec struct { | |||
// +optional | |||
ClusterModules []ClusterModule `json:"clusterModules,omitempty"` | |||
|
|||
// DisableClusterModule is used to explicitly turn off the ClusterModule feature. | |||
// This should work along side NodeAntiAffinity feature flag. | |||
// If the NodeAntiAffinity feature flag is turned off, this will be disregarded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine but has to be updated once the feature flag graduates and is removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. Will do it once it is graduated
@RenilRaj-BR test failures are legit. If you look into conversion there is just the entry of // WARNING: in.DisableClusterModule requires manual conversion: does not exist in peer-type You need to establish some manual conversion for this field to not add it to the v1alpha3 and v1alpha4 API. |
What this PR does:
The cluster module is currently enabled for all vSphere clusters based on the anti-affinity feature flag, with no option to disable its creation if the user doesn't want this feature. This PR introduces a DisableClusterModule field to the vSphereCluster API, allowing users to control the creation of a cluster module. However, this field is only applicable when the NodeAntiAffinity feature flag is enabled; otherwise, it is ignored.