Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add extra information in the supported labels and annotations tables #10425

Merged
merged 1 commit into from
Aug 27, 2024
Merged

📖 Add extra information in the supported labels and annotations tables #10425

merged 1 commit into from
Aug 27, 2024

Conversation

hackeramitkumar
Copy link
Member

What this PR does / why we need it:
I have sorted all of the labels and annotations in alphabatical order. And also added 2 new columns in the table, one for Manage By and other for the Applies to.

Which issue(s) this PR fixes
Fixes #7441

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2024
@hackeramitkumar hackeramitkumar changed the title 📖 Add extra information in the supported labels and annotations tables [WIP] 📖 Add extra information in the supported labels and annotations tables Apr 13, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2024
fabriziopandini
fabriziopandini reviewed May 7, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackeramitkumar sorry if I lost track of this PR in my notification backlog 😅

This is an outstanding research work, it adds a lot of value to this page.
I made a first pass on annotations.
I will try to get back to labels ASAP

docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@hackeramitkumar
Copy link
Member Author

Hi @fabriziopandini ,

Thanks for reviewing the annotations and providing suggestions. I have resolved all the comments and made the suggested changes to the annotations. Could you please review the labels as well?

@sbueringer
Copy link
Member

cc @fabriziopandini ^°

fabriziopandini
fabriziopandini reviewed Aug 2, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delay, I somehow missed notifications about this PR

one last nit otherwise lgtm

docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
@hackeramitkumar
sorted labels and annotations in alphabatical order
f1049c2 
Signed-off-by: hackeramitkumar <amit9116260192@gmail.com>
@hackeramitkumar hackeramitkumar changed the title [WIP] 📖 Add extra information in the supported labels and annotations tables 📖 Add extra information in the supported labels and annotations tables Aug 26, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2024
@hackeramitkumar
Copy link
Member Author

@fabriziopandini Sorry for the delay, I missed the notification.
Now I have made the changes as per your suggestion. Please have a look.
Thanks

@fabriziopandini
Copy link
Member

Thanks for the work on this PR @hackeramitkumar
/lgtm
/approve

/cherry-pick release-1.8

@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

Thanks for the work on this PR @hackeramitkumar
/lgtm
/approve

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9ee382076a7db104153fe93f8ae97bb84753972e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3ae9fe1 into kubernetes-sigs:main Aug 27, 2024
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Aug 27, 2024
@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #11102

In response to this:

Thanks for the work on this PR @hackeramitkumar
/lgtm
/approve

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase Awaiting requested review from richardcase

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Add extra information in the supported labels and annotations tables
5 participants
@hackeramitkumar @sbueringer @fabriziopandini @k8s-infra-cherrypick-robot @k8s-ci-robot