🌱 Log controller name in predicates

[Karthik-K-N]

What this PR does / why we need it:
This PR tries to improve the logging of predicate to include more key value pairs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10818

/area logging

[Karthik-K-N]

@sbueringer regarding the kind value being empty I see multiple issues regarding Typemeta being empty kubernetes-sigs/controller-runtime#1735 and needs an upstream fix.

Meanwhile I think we can fetch the GVK with help of client like client.GroupVersionKindFor(obj), But which might require predicate signature change or creating a new predicate. Should I do that?

Could you please help me If any other better way of fetching find GVK or making object contain GVK.

[sbueringer]

@Karthik-K-N I'll look into, but I'll need some time

[Karthik-K-N]

@sbueringer I thought of using predicate_controller as the key for logging controller name, Please suggest better name if you have it in mind. Also I tried to add it across all the controllers.

[sbueringer]

@sbueringer I thought of using predicate_controller as the key for logging controller name, Please suggest better name if you have it in mind. Also I tried to add it across all the controllers.

I would use "controller". This should intentionally match up with the controller key/value pair of other code of the same controller (which controller-runtime does for us for everything that gets a logger out of the context passed into Reconcile(ctx context, req Request))

[Karthik-K-N]

@sbueringer I thought of using predicate_controller as the key for logging controller name, Please suggest better name if you have it in mind. Also I tried to add it across all the controllers.

I would use "controller". This should intentionally match up with the controller key/value pair of other code of the same controller (which controller-runtime does for us for everything that gets a logger out of the context passed into Reconcile(ctx context, req Request))

I got your point and made the changes to use controller as the key, Earlier my intention was to uniquely identify predicate logs using that key.
Please take a look when you get some time and let me know if any further changes are required.

[sbueringer]

Thx, two nits

[sbueringer]

Thank you!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 893b1af962ca8d1e89508efdb21e42a3c2ae9b58

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Karthik-K-N]

/retest

[sbueringer]

Changed the PR description to re-trigger the title verifier. We merged a change there which had a bug, but that was fixed just now