Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Fix CAPZ redirection links in quick-start page #11104

Closed
wants to merge 2 commits into from
Closed

📖 Fix CAPZ redirection links in quick-start page #11104

wants to merge 2 commits into from

Conversation

NareshKoduru
Copy link
Contributor

This PR fixes the broken links that redirect pages in the CAPZ book.

/area documentation

@k8s-ci-robot k8s-ci-robot added the area/documentation Issues or PRs related to documentation label Aug 27, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 27, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: joshfrench / name: Josh French (5134812)
  • ✅ login: NareshKoduru / name: NareshKoduru (a6b429b)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign killianmuldoon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @NareshKoduru. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 28, 2024
@chrischdi
Copy link
Member

/easycla

@NareshKoduru
Copy link
Contributor Author

/retest

@enxebre
Copy link
Member

enxebre commented Aug 28, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 28, 2024
@sbueringer
Copy link
Member

Change seems fine

@NareshKoduru please check the bot comments above regarding CLA

@sbueringer
Copy link
Member

sbueringer commented Aug 28, 2024 •
edited
Loading

/assign @mboersma
(to confirm the Azure link changes)

@jackfrancis
Copy link
Contributor

@willie-yao could you take a look at this?

@willie-yao
Copy link
Contributor

Yup!

/assign

willie-yao
willie-yao approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 77a1593f437ea9d0ad19844e41717867a6660970

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2024
joshfrench and others added 2 commits August 29, 2024 12:46
@joshfrench @NareshKoduru
cluster.status.conditions.reason may indeed be empty
5134812 
regenerate CRDs

🌱 test: improve autoscale tests for to/from zero and running autoscaler in bootstrap cluster (kubernetes-sigs#11082)

* test: allow deploying autoscaler to management cluster

* test: make machine pools optional in autoscaler test

* test: implement optional scale from/to zero tests for autoscale

* test: allow modification of apigroup for infrastructure

* test: wait for rollouts to finish in autoscaler tests

* test: drop cleaning up autoscaler for machine pools

* review fix

* add comment about AutoScaleFromZero

* remove autoscale from zero test for unsupported MachinePools

* review fixes

update cert-manager to 1.15.3

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>

Collect additional logs with CAPD log collector

Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>

:seedling: Bump tj-actions/changed-files in the all-github-actions group

Bumps the all-github-actions group with 1 update: [tj-actions/changed-files](https://github.com/tj-actions/changed-files).

Updates `tj-actions/changed-files` from 44.5.7 to 45.0.0
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@c65cd88...40853de)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all-github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>

:seedling: Bump google.golang.org/api

Bumps the all-go-mod-patch-and-minor group with 1 update in the /hack/tools directory: [google.golang.org/api](https://github.com/googleapis/google-api-go-client).

Updates `google.golang.org/api` from 0.193.0 to 0.194.0
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.193.0...v0.194.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

🌱  Fix error handling when the resource is not found (kubernetes-sigs#10907)

* fix: error handling when the resource is not found

Signed-off-by: sivchari <shibuuuu5@gmail.com>

* fix: test

* fix: owner cluster handling

Signed-off-by: sivchari <shibuuuu5@gmail.com>

* remove duplicated error

Signed-off-by: sivchari <shibuuuu5@gmail.com>

* remove log variable

Signed-off-by: sivchari <shibuuuu5@gmail.com>

* fix error handling when the controller reads the cluster

Signed-off-by: sivchari <shibuuuu5@gmail.com>

* revert test modification

Signed-off-by: sivchari <shibuuuu5@gmail.com>

* delete log

Signed-off-by: sivchari <shibuuuu5@gmail.com>

* remove unnecessary deletion

Signed-off-by: sivchari <shibuuuu5@gmail.com>

* add detail of error

Signed-off-by: sivchari <shibuuuu5@gmail.com>

---------

Signed-off-by: sivchari <shibuuuu5@gmail.com>

Add nilIsZero to all KSM metric configs where needed

Signed-off-by: Tobias Giese <tgiese@nvidia.com>

sorted labels and annotations in alphabatical order

Signed-off-by: hackeramitkumar <amit9116260192@gmail.com>

📖 Fix CAPZ redirection links in quick-start page

Trigger Build

Trigger Build

Add nilIsZero to all KSM metric configs where needed

Signed-off-by: Tobias Giese <tgiese@nvidia.com>

sorted labels and annotations in alphabatical order

Signed-off-by: hackeramitkumar <amit9116260192@gmail.com>

📖 Fix CAPZ redirection links in quick-start page

Trigger Build

📖 Fix CAPZ redirection links in quick-start page
@NareshKoduru
Trigger Build
a6b429b
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2024
@NareshKoduru
Copy link
Contributor Author

/hold

@willie-yao , @sbueringer , @jackfrancis , Can you please consider #11109 instead of this PR please. Thanks
Apologies I messed up my local branch and pushed the commits into this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@NareshKoduru NareshKoduru mentioned this pull request Aug 29, 2024
Merged
@chrischdi
Copy link
Member

/close
in favor of #11109

@k8s-ci-robot
Copy link
Contributor

@chrischdi: Closed this PR.

In response to this:

/close
in favor of #11109

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@NareshKoduru NareshKoduru deleted the redirection_link_capz branch August 29, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willie-yao willie-yao willie-yao approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@mboersma mboersma

@willie-yao willie-yao

Labels
area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@NareshKoduru @k8s-ci-robot @chrischdi @enxebre @sbueringer @jackfrancis @willie-yao @mboersma @joshfrench