Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 re-add /finalizers subresource RBAC #11106

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Aug 27, 2024

What this PR does / why we need it:

Fix /finalizers RBAC removed in:

Update permissions on /finalizers subresrouce is required on managment clusters with 'OwnerReferencesPermissionEnforcement' plugin enabled. See: https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#ownerreferencespermissionenforcement

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #11098

/area api

@k8s-ci-robot k8s-ci-robot added area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 27, 2024
Update permissions on /finalizers subresrouce is required on managment clusters with 'OwnerReferencesPermissionEnforcement' plugin enabled.
@muraee muraee changed the title 🐛 re-add /finalizers subresource rbac 🐛 re-add /finalizers subresource RBAC Aug 27, 2024
@enxebre
Copy link
Member

enxebre commented Aug 28, 2024

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 65b7ade2cd8d4b0c1b3ce55c019678d0ca04dc96

@chrischdi
Copy link
Member

/approve

Thanks for fixing this!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrischdi
Copy link
Member

/cherry-pick release-1.8

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@k8s-infra-cherrypick-robot

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 703cc70 into kubernetes-sigs:main Aug 30, 2024
24 of 25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Aug 30, 2024
@k8s-infra-cherrypick-robot

@chrischdi: #11106 failed to apply on top of branch "release-1.8":

Applying: re-add /finalizers subresource RBAC
Using index info to reconstruct a base tree...
M	bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go
M	config/rbac/role.yaml
M	exp/addons/internal/controllers/clusterresourceset_controller.go
M	internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
M	test/infrastructure/docker/config/rbac/role.yaml
M	test/infrastructure/inmemory/config/rbac/role.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/infrastructure/inmemory/config/rbac/role.yaml
CONFLICT (content): Merge conflict in test/infrastructure/inmemory/config/rbac/role.yaml
Auto-merging test/infrastructure/docker/config/rbac/role.yaml
CONFLICT (content): Merge conflict in test/infrastructure/docker/config/rbac/role.yaml
Auto-merging internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
Auto-merging exp/addons/internal/controllers/clusterresourceset_controller.go
Auto-merging config/rbac/role.yaml
CONFLICT (content): Merge conflict in config/rbac/role.yaml
Auto-merging bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 re-add /finalizers subresource RBAC
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAPI controllers fail to set ownerReference
6 participants