🌱 Revert "Add nilIsZero to all KSM metric configs where needed" #11107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 82adc39. Signed-off-by: Tobias Giese <tgiese@nvidia.com>
k8s-ci-robot
added
area/metrics
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 64c29fc5c25384501d23775fbed56edf73e34a64
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I assume this time we tried the config? :) |
|
For reference, this is the previous PR: #11101 |
|
Thanks for cleaning it up again :-) |
The config was also tested with the previous PR. There is no error message, it simply does not work (the option has no effect). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 82adc39.
What this PR does / why we need it:
Unfortunately,
nilIsZerois not implemented fortype: StateSet, seeconfig_metrics_types.go#L48-L59. Sorry folks 😞Also there is no error in the logs using it for this type.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area metrics