Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Revert "Add nilIsZero to all KSM metric configs where needed" #11107

Merged
merged 1 commit into from
Aug 27, 2024
+0 −34
Merged

🌱 Revert "Add nilIsZero to all KSM metric configs where needed" #11107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions config/metrics/crd-metrics-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ spec:
- conditions
valueFrom:
- status
nilIsZero: true
type: StateSet
- name: status_condition_last_transition_time
help: The condition last transition time of a clusterclass.
Expand All @@ -80,7 +79,6 @@ spec:
- conditions
valueFrom:
- lastTransitionTime
nilIsZero: true
type: Gauge
- name: owner
help: Owner references.
Expand Down Expand Up @@ -177,7 +175,6 @@ spec:
path:
- status
- phase
nilIsZero: true
type: StateSet
- name: created
help: Unix creation timestamp.
Expand Down Expand Up @@ -215,7 +212,6 @@ spec:
- conditions
valueFrom:
- status
nilIsZero: true
type: StateSet
- name: status_condition_last_transition_time
help: The condition last transition time of a cluster.
Expand All @@ -231,7 +227,6 @@ spec:
- conditions
valueFrom:
- lastTransitionTime
nilIsZero: true
type: Gauge
- groupVersionKind:
group: controlplane.cluster.x-k8s.io
Expand Down Expand Up @@ -353,7 +348,6 @@ spec:
- conditions
valueFrom:
- status
nilIsZero: true
type: StateSet
- name: status_condition_last_transition_time
help: The condition last transition time of a kubeadmcontrolplane.
Expand All @@ -369,7 +363,6 @@ spec:
- conditions
valueFrom:
- lastTransitionTime
nilIsZero: true
type: Gauge
- name: owner
help: Owner references.
Expand Down Expand Up @@ -454,7 +447,6 @@ spec:
- conditions
valueFrom:
- status
nilIsZero: true
type: StateSet
- name: status_condition_last_transition_time
help: The condition last transition time of a kubeadmconfig.
Expand All @@ -470,7 +462,6 @@ spec:
- conditions
valueFrom:
- lastTransitionTime
nilIsZero: true
type: Gauge
- name: owner
help: Owner references.
Expand Down Expand Up @@ -618,7 +609,6 @@ spec:
path:
- status
- phase
nilIsZero: true
type: StateSet
- name: created
help: Unix creation timestamp.
Expand Down Expand Up @@ -656,7 +646,6 @@ spec:
- conditions
valueFrom:
- status
nilIsZero: true
type: StateSet
- name: status_condition_last_transition_time
help: The condition last transition time of a machine.
Expand All @@ -672,7 +661,6 @@ spec:
- conditions
valueFrom:
- lastTransitionTime
nilIsZero: true
type: Gauge
- name: owner
help: Owner references.
Expand Down Expand Up @@ -880,7 +868,6 @@ spec:
- conditions
valueFrom:
- status
nilIsZero: true
type: StateSet
- name: status_condition_last_transition_time
help: The condition last transition time of a machinedeployment.
Expand All @@ -896,7 +883,6 @@ spec:
- conditions
valueFrom:
- lastTransitionTime
nilIsZero: true
type: Gauge
- name: owner
help: Owner references.
Expand Down Expand Up @@ -951,7 +937,6 @@ spec:
path:
- status
- currentHealthy
nilIsZero: true
type: Gauge
- name: status_expected_machines
help: Total number of pods counted by this machinehealthcheck.
Expand All @@ -960,7 +945,6 @@ spec:
path:
- status
- expectedMachines
nilIsZero: true
type: Gauge
- name: status_remediations_allowed
help: Number of machine remediations that are currently allowed.
Expand All @@ -969,7 +953,6 @@ spec:
path:
- status
- remediationsAllowed
nilIsZero: true
type: Gauge
- name: created
help: Unix creation timestamp.
Expand Down Expand Up @@ -1007,7 +990,6 @@ spec:
- conditions
valueFrom:
- status
nilIsZero: true
type: StateSet
- name: status_condition_last_transition_time
help: The condition last transition time of a machinehealthcheck.
Expand All @@ -1023,7 +1005,6 @@ spec:
- conditions
valueFrom:
- lastTransitionTime
nilIsZero: true
type: Gauge
- name: owner
help: Owner references.
Expand Down Expand Up @@ -1123,7 +1104,6 @@ spec:
path:
- status
- fullyLabeledReplicas
nilIsZero: true
type: Gauge
- name: status_replicas_ready
help: The number of ready replicas per machineset.
Expand Down Expand Up @@ -1179,7 +1159,6 @@ spec:
- conditions
valueFrom:
- status
nilIsZero: true
type: StateSet
- name: status_condition_last_transition_time
help: The condition last transition time of a machineset.
Expand All @@ -1195,7 +1174,6 @@ spec:
- conditions
valueFrom:
- lastTransitionTime
nilIsZero: true
type: Gauge
- name: owner
help: Owner references.
Expand Down Expand Up @@ -1332,7 +1310,6 @@ spec:
path:
- status
- phase
nilIsZero: true
type: StateSet
- name: created
help: Unix creation timestamp.
Expand Down Expand Up @@ -1370,7 +1347,6 @@ spec:
- conditions
valueFrom:
- status
nilIsZero: true
type: StateSet
- name: status_condition_last_transition_time
help: The condition last transition time of a machinepool.
Expand All @@ -1386,7 +1362,6 @@ spec:
- conditions
valueFrom:
- lastTransitionTime
nilIsZero: true
type: Gauge
- name: owner
help: Owner references.
Expand Down
1 change: 0 additions & 1 deletion config/metrics/templates/cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,4 @@
path:
- status
- phase
nilIsZero: true
type: StateSet
2 changes: 0 additions & 2 deletions config/metrics/templates/common_metrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
- conditions
valueFrom:
- status
nilIsZero: true
type: StateSet
- name: status_condition_last_transition_time
help: The condition last transition time of a ${RESOURCE}.
Expand All @@ -50,5 +49,4 @@
- conditions
valueFrom:
- lastTransitionTime
nilIsZero: true
type: Gauge
1 change: 0 additions & 1 deletion config/metrics/templates/machine.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,5 +127,4 @@
path:
- status
- phase
nilIsZero: true
type: StateSet
3 changes: 0 additions & 3 deletions config/metrics/templates/machinehealthcheck.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
path:
- status
- currentHealthy
nilIsZero: true
type: Gauge
- name: status_expected_machines
help: Total number of pods counted by this machinehealthcheck.
Expand All @@ -43,7 +42,6 @@
path:
- status
- expectedMachines
nilIsZero: true
type: Gauge
- name: status_remediations_allowed
help: Number of machine remediations that are currently allowed.
Expand All @@ -52,5 +50,4 @@
path:
- status
- remediationsAllowed
nilIsZero: true
type: Gauge
1 change: 0 additions & 1 deletion config/metrics/templates/machinepool.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,5 +116,4 @@
path:
- status
- phase
nilIsZero: true
type: StateSet
1 change: 0 additions & 1 deletion config/metrics/templates/machineset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@
path:
- status
- fullyLabeledReplicas
nilIsZero: true
type: Gauge
- name: status_replicas_ready
help: The number of ready replicas per machineset.
Expand Down
Loading