-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 clusterctl: add nutanix ipam & runtime extensions providers #11135
base: main
Are you sure you want to change the base?
🌱 clusterctl: add nutanix ipam & runtime extensions providers #11135
Conversation
jimmidyson
commented
Sep 4, 2024
- 🌱 clusterctl: add nutanix ipam provider
- 🌱 clusterctl: add nutanix runtime extensions provider
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e0976e0
to
a74ed48
Compare
a74ed48
to
aca26cf
Compare
/area clusterctl |
/label tide/merge-method-squash |
@elmiko @JoelSpeed if you have time for review 🙏 should be pretty quick and easy hopefully. |
@@ -98,13 +98,19 @@ const ( | |||
// IPAM providers. | |||
const ( | |||
InClusterIPAMProviderName = "in-cluster" | |||
NutanixIPAMProviderName = "nutanix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NutanixIPAMProviderName = "nutanix" | |
NutanixIPAMProviderName = "nutanix-cloud-native-nutanix" |
To follow the conventions at https://main.cluster-api.sigs.k8s.io/clusterctl/provider-contract.html#adding-a-provider-to-clusterctl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have an infra provider simply called nutanix at https://github.com/kubernetes-sigs/cluster-api/blob/main/cmd/clusterctl/client/config/providers_client.go#L55 and it would be great if we could use the same name for these other provider types for consistency 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Maybe it's fine if a GitHub org already "claimed" the name via another provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would make sense. Fine for me if we have an agreement :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabriziopandini @vincepri WDYT?
) | ||
|
||
// Add-on providers. | ||
const ( | ||
HelmAddonProviderName = "helm" | ||
) | ||
|
||
// Runtime extensions providers. | ||
const ( | ||
NutanixRuntimeExtensionsProviderName = "nutanix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NutanixRuntimeExtensionsProviderName = "nutanix" | |
NutanixRuntimeExtensionsProviderName = "nutanix-cloud-native-nutanix" |
To follow the conventions at https://main.cluster-api.sigs.k8s.io/clusterctl/provider-contract.html#adding-a-provider-to-clusterctl
| CAIPAMX | cluster.x-k8s.io/provider=ipam-nutanix | | ||
| CAREN | cluster.x-k8s.io/provider=runtime-extensions-nutanix | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised in one that it uses X for the provider identifier and the other uses N, should these not be consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm from the UK where carex is a major brand of soap 🤣 but you're right it would make sense to rename it to be consistent. I'll get on to that when I get a chance.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |