🌱 golangci: add comments to enabled linters #11142
Conversation
also fixes some deprecations
k8s-ci-robot
added
area/ci
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b842ae39d993eb72752e51a09e82da38b738ab04
|
| @@ -4,62 +4,55 @@ run: | |||
| build-tags: | |||
| - tools | |||
| - e2e | |||
| skip-files: | |||
There was a problem hiding this comment.
We should write this configuration in issues section. It's good modification.
| @@ -187,7 +180,6 @@ linters-settings: | |||
| alias: infraexpv1 | |||
| nolintlint: | |||
| allow-unused: false | |||
| allow-leading-space: false | |||
There was a problem hiding this comment.
It's okay due to this field isn't existing.
|
Maybe, this PR is part of #11132 . |
I can rebase once that's merged. This one is primarily about the linter descriptions. |
|
nice to have comments near each linter, I will take a look to other changes ASAP |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
We're using an adapted version of CAPI's golangci-lint config. I've recently updated the linter list with comments summarising what each linter does, since it's quite cumbersome to look it up in case you want to know.
This should also make it easier for other projects to adopt this configuration.
I've also removed two linters:
sqlpackage, and I hope we're not using that anywhereI also removed one deprecated parameter and moved file exclusions to the new location.
/area ci