Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 condition: fix godoc for MachineNodeHealthyCondition #11178

Merged

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Sep 12, 2024

What this PR does / why we need it:

We do not check NodeNetworkUnavailable.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Follow-up of #11145 (comment)

@chrischdi chrischdi added the area/machine Issues or PRs related to machine lifecycle management label Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2024
@sbueringer
Copy link
Member

@fabriziopandini

I think this PR should be merged in any case. Our implementation simply doesn't check NodeNetworkUnavailable, so it makes sense that our documentation matches that.

I have absolutely no clue if we should check the NodeNetworkUnavailable condition going forward, probably would require some additional research. And I would see it orthogonal to all ongoing efforts.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3fa39d964d40ffebe1346ecb28dbcf06d9b1603

@chrischdi
Copy link
Member Author

I have absolutely no clue if we should check the NodeNetworkUnavailable condition going forward, probably would require some additional research. And I would see it orthogonal to all ongoing efforts

Wild guess: maybe not necessary because its part of Ready

@chrischdi
Copy link
Member Author

I tried to look it up, the comment was added in:

But the condition is only mentioned on the comment.

@chrischdi
Copy link
Member Author

/assign @fabriziopandini

@fabriziopandini
Copy link
Member

/lgtm
/approve

Added a note about NodeNetworkUnavailable in #11105

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4d9693a into kubernetes-sigs:main Sep 19, 2024
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machine Issues or PRs related to machine lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants