✨ Update MHC with v1Beta2 status #11290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/machinehealthcheck
k8s-ci-robot
added
the
size/XXL
sbueringer
reviewed
Oct 15, 2024
internal/controllers/machinehealthcheck/machinehealthcheck_targets.go
Outdated
Show resolved
Hide resolved
sbueringer
reviewed
Oct 16, 2024
internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
Outdated
Show resolved
Hide resolved
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: de7c65b4fc33b1d3f776e80a3d4f91d820e3f8c7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold (for squash) |
k8s-ci-robot
added
the
do-not-merge/hold
fabriziopandini
force-pushed
the
update-v1beta2-status-mhc-controller
branch
from
9656771
to
fcb8cd5
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds code for updating MachineHealthCheck with v1beta2 status.
Also MachineHealthCheck now updates targeted Machines with v1beta2 status too.
Which issue(s) this PR fixes:
Rif #11105
/area machinehealthcheck