🌱 Remove unused Paused conditions & minor MHC godoc fixes #11298
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3e28781d70d0d999b65ec756f8abc15c8c39987f
|
| @@ -661,7 +661,7 @@ func TestMachineHealthCheck_Reconcile(t *testing.T) { | |||
| }).Should(Equal(1)) | |||
| }) | |||
|
|
|||
| t.Run("it marks unhealthy machines for remediation when the unhealthy Machines exceed MaxUnhealthy", func(t *testing.T) { | |||
| t.Run("it doesn't mark unhealthy machines for remediation when the unhealthy Machines exceed MaxUnhealthy", func(t *testing.T) { | |||
There was a problem hiding this comment.
I'm not sure this is entirely correct, because it sets HealthCheckSucceeded=false, but it doesn't add OwnerRemediated. might be
| t.Run("it doesn't mark unhealthy machines for remediation when the unhealthy Machines exceed MaxUnhealthy", func(t *testing.T) { | |
| t.Run("it mark unhealthy machines for remediation but it doesn't engage machine owner when the unhealthy Machines exceed MaxUnhealthy", func(t *testing.T) { |
Same below
There was a problem hiding this comment.
I used slightly different wording, but I think now it expresses what the test is doing
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-fixups-mhc
branch
from
a48485e
to
bb7d7e6
Compare
k8s-ci-robot
removed
the
lgtm
|
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d17beefcf56f3358d44da6afc81d17e84ddded3f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #