Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Deprecate ClusterCacheTracker #11312

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Deprecate ClusterCacheTracker #11312

wants to merge 1 commit into from
+20 −3

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #11272

@sbueringer
Deprecate ClusterCacheTracker
4ca02ab 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Oct 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sbueringer. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 19, 2024
sbueringer
sbueringer commented Oct 19, 2024
View reviewed changes
controlplane/kubeadm/internal/controllers/controller.go
@@ -121,9 +121,6 @@ func (r *KubeadmControlPlaneReconciler) SetupWithManager(ctx context.Context, mg
r.ssaCache = ssa.NewCache()

if r.managementCluster == nil {
if r.ClusterCache == nil {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor cleanup, this check is never used because we would already panic above now.

I have a follow-up to introduce proper input validation for all SetupWithManager funcs

sbueringer
sbueringer commented Oct 19, 2024
View reviewed changes
controllers/remote/cluster_cache_reconciler.go
@@ -32,6 +32,8 @@ import (

// ClusterCacheReconciler is responsible for stopping remote cluster caches when
// the cluster for the remote cache is being deleted.
//
// Deprecated: This will be removed in Cluster API v1.10, use clustercache.ClusterCache instead.
Copy link
Member Author

@sbueringer sbueringer Oct 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to give folks one release time to migrate away (ClusterCacheTracker would be removed with the v1.10 (April 2025) release).

Folks can always just copy the old ClusterCacheTracker if they want to continue to use it.

Copy link
Member

@fabriziopandini fabriziopandini Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, should we change the PR type to make this surface in the release notes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To what do you want to change it?

(Just adding the deprecation itself is not a breaking change)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note here: #11092 (comment)

@sbueringer
Copy link
Member Author

/assign @vincepri @fabriziopandini @chrischdi

@sbueringer sbueringer mentioned this pull request Oct 19, 2024
Open
9 tasks
@sbueringer sbueringer added the area/clustercachetracker Issues or PRs related to the clustercachetracker label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Oct 21, 2024
fabriziopandini
fabriziopandini reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9a38d4c9d1a81b823d1833d87e35e43d21350f68

@sbueringer sbueringer mentioned this pull request Oct 21, 2024
Open
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@chrischdi chrischdi

@vincepri vincepri

@fabriziopandini fabriziopandini

Labels
area/clustercachetracker Issues or PRs related to the clustercachetracker cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @k8s-ci-robot @fabriziopandini @chrischdi @vincepri