-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 github: add workflow to auto-approve golangci-lint if ok-to-test label is set #9244
🌱 github: add workflow to auto-approve golangci-lint if ok-to-test label is set #9244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall, just one nit
7d24a19
to
8f5b052
Compare
/area ci /lgtm Let's give others some time to review and otherwise merge next week and just give it a try |
LGTM label has been added. Git tree hash: 0cf2959b6f855a97ddc0fc848f9ef78303d7233f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Prior art: https://github.com/kubernetes-sigs/metrics-server/blob/9dbb59e99addce5956f65d6e44749fb36eef339e/.github/workflows/gh-workflow-approve.yaml
Tested at chrischdi/cluster-api-provider-vsphere#4
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #9215