Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump cert-manager to v1.13.0 #9408

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

furkatgofurov7
Copy link
Member

What this PR does / why we need it:
Updates cert-manager to v1.13.0

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9405

/area clusterctl

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 69a1777 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a4a56b12d80a3bdc03d5a26c53aa1bbc6c6c15a6

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@furkatgofurov7
Copy link
Member Author

@killianmuldoon @chrischdi do we need to cherry-pick this?

@k8s-ci-robot k8s-ci-robot merged commit b8ff771 into kubernetes-sigs:main Sep 13, 2023
23 of 24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Sep 13, 2023
@sbueringer
Copy link
Member

sbueringer commented Sep 13, 2023

I assume there is nothing breaking in the release notes? (also relevant for main)

@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Sep 13, 2023

I assume there is nothing breaking in the release notes? (also relevant for main)

@sbueringer from the release notes:

  • ⚠️ ⚠️ BREAKING ⚠️ ⚠️ : If you deploy cert-manager using helm and have .featureGates value set, the features defined there will no longer be passed to cert-manager webhook, only to cert-manager controller. Use webhook.featureGates field instead to define features to be enabled on webhook.
  • Potentially breaking: If you were, for some reason, passing cert-manager controller's features to webhook's --feature-gates flag, this will now break (unless the webhook actually has a feature by that name).
  • ⚠️ possibly breaking: Webhook validation of CertificateRequest resources is stricter now: all KeyUsages and ExtendedKeyUsages must be defined directly in the CertificateRequest resource, the encoded CSR can never contain more usages that defined there.

Maybe we should not backport it in general, since it is a minor version anyway?

@sbueringer
Copy link
Member

sbueringer commented Sep 13, 2023

Thx for looking it up.

I would prefer backporting. The alternative is that sooner or later we're using an unsupported version which is not great.

@furkatgofurov7
Copy link
Member Author

Thx for looking it up.

I would prefer backporting. The alternative is that sooner or later we're using an unsupported version which is not great.

Assuming you meant only release-1.5:

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@furkatgofurov7: new pull request created: #9413

In response to this:

Thx for looking it up.

I would prefer backporting. The alternative is that sooner or later we're using an unsupported version which is not great.

Assuming you meant only release-1.5:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

I think we should also backport this to 1.4

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@killianmuldoon: new pull request created: #9414

In response to this:

I think we should also backport this to 1.4

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@g-gaston
Copy link
Contributor

/remove-area clusterctl
/area dependency

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes and removed area/clusterctl Issues or PRs related to clusterctl labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump to cert-manager v1.13.0
7 participants