Skip to content

Commit

Permalink
Merge pull request #8 from justinsb/push_static_image
Browse files Browse the repository at this point in the history
build: Add non-bazel images to push script
  • Loading branch information
k8s-ci-robot authored Sep 2, 2024
2 parents b3b9146 + 454f12d commit 8a5229d
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 3 deletions.
3 changes: 3 additions & 0 deletions dev/push-etcd-manager.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,6 @@ fi

# Build and upload etcd-manager images & binaries
DOCKER_REGISTRY=${DOCKER_REGISTRY} DOCKER_IMAGE_PREFIX=${DOCKER_IMAGE_PREFIX} DOCKER_TAG=${VERSION} make push

# Build and upload non-bazel images
BUILD_PLATFORMS=linux/amd64,linux/arm64 BUILD_ARGS=--push IMAGE_PREFIX=${DOCKER_REGISTRY}/${DOCKER_IMAGE_PREFIX} IMAGE_TAG=${VERSION} ${REPO_ROOT}/dev/tasks/build-images
11 changes: 8 additions & 3 deletions dev/tasks/build-images
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,16 @@ if [[ -z "${IMAGE_PREFIX:-}" ]]; then
exit 1
fi

IMAGE_TAG=${IMAGE_PREFIX}/etcd-manager-minimal:latest
IMAGE_TAG=${IMAGE_PREFIX}etcd-manager-static:latest

if [[ -z "${BUILD_ARGS:-}" ]]; then
BUILD_ARGS="--load"
fi
echo "Building image ${IMAGE_TAG} with args ${BUILD_ARGS:-}"

docker buildx build ${BUILD_ARGS} -t ${IMAGE_TAG} -f ./images/etcd-manager-minimal/Dockerfile .
if [[ -z "${BUILD_PLATFORMS:-}" ]]; then
BUILD_PLATFORMS="local"
fi

echo "Building image ${IMAGE_TAG} for platforms ${BUILD_PLATFORMS} with args ${BUILD_ARGS:-}"

docker buildx build ${BUILD_ARGS} --platform ${BUILD_PLATFORMS} -t ${IMAGE_TAG} -f ./images/etcd-manager-static/Dockerfile .
File renamed without changes.
2 changes: 2 additions & 0 deletions images/etcd-manager-static/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
etcd-manager-static is used to run etcd-manager with static configuration;
it does not support cloud-based peer discovery, and it cannot mount cloud volumes.

0 comments on commit 8a5229d

Please sign in to comment.