-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new flag to allow CA as text argument for kubelet client #1516
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Saurabh Choudhary <csauoss@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: csauoss The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @csauoss! |
Hi @csauoss. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign |
@dgrisonnet I do not quite understand the check that failed here as part of build. Is there anything I need to setup? Thanks! |
It sounds like an unrelated error. /retest |
@dgrisonnet thanks for retesting it. Looks like its all good. can you please review and approve it when you get a chance? |
What this PR does / why we need it:
--kubelet-certificate-authority-text
to allow passing CA as text for kubelet client. Added corresponding unit tests and updated docs.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1256