Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: fix remote error: tls: internal error #1522

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix: fix remote error: tls: internal error #1522

wants to merge 6 commits into from

Conversation

dongjiang1989
Copy link

What this PR does / why we need it:

ref: golang/go#58434

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1480

@dongjiang1989
fix tls bug
e90c23d 
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @dongjiang1989!

It looks like this is your first PR to kubernetes-sigs/metrics-server 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/metrics-server has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2024
@nathan-bowman nathan-bowman mentioned this pull request Jul 18, 2024
Closed
@dongjiang1989
Copy link
Author

@yanggangtony @dgrisonnet PTAL

@dgrisonnet
Copy link
Member

/triage accepted
/assign

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 25, 2024
@dongjiang1989
Copy link
Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@dongjiang1989: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dongjiang1989
Copy link
Author

/triage accepted /assign

@dgrisonnet Please add ok-to-test
thanks

@NahumLitvin
Copy link

NahumLitvin commented Jul 28, 2024 •
edited
Loading

@yanggangtony @dgrisonnet any ETA on this? this causes lots of chaos in my cluster

@marcelaraujo
Copy link

Hi @dongjiang1989

Even after deploying a new docker image with your patch, I'm still getting the error message

E0729 22:37:58.058665       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.171.9:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-171-9.ec2.internal"
E0729 22:39:43.033961       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.174.222:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-174-222.ec2.internal"
E0729 22:39:58.162997       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.149.46:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-149-46.ec2.internal"
E0729 22:42:13.112497       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.242.20:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-242-20.ec2.internal"

@dongjiang1989
Copy link
Author

dongjiang1989 commented Jul 30, 2024 •
edited
Loading

Hi @dongjiang1989

Even after deploying a new docker image with your patch, I'm still getting the error message

E0729 22:37:58.058665       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.171.9:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-171-9.ec2.internal"
E0729 22:39:43.033961       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.174.222:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-174-222.ec2.internal"
E0729 22:39:58.162997       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.149.46:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-149-46.ec2.internal"
E0729 22:42:13.112497       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.242.20:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-242-20.ec2.internal"

@marcelaraujo Please show your kubernetes version and metrics-server verison?

@marcelaraujo
Copy link

marcelaraujo commented Jul 31, 2024 •
edited
Loading

Hi @dongjiang1989
Even after deploying a new docker image with your patch, I'm still getting the error message

E0729 22:37:58.058665       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.171.9:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-171-9.ec2.internal"
E0729 22:39:43.033961       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.174.222:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-174-222.ec2.internal"
E0729 22:39:58.162997       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.149.46:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-149-46.ec2.internal"
E0729 22:42:13.112497       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.242.20:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-242-20.ec2.internal"

kubernetes version and metrics-server verison?

Hi @dongjiang1989
Even after deploying a new docker image with your patch, I'm still getting the error message

E0729 22:37:58.058665       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.171.9:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-171-9.ec2.internal"
E0729 22:39:43.033961       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.174.222:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-174-222.ec2.internal"
E0729 22:39:58.162997       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.149.46:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-149-46.ec2.internal"
E0729 22:42:13.112497       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.242.20:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-242-20.ec2.internal"

@marcelaraujo Please show your kubernetes version and metrics-server verison?

K8S: v1.29.4
Metrics-server: Latest + your patch

@dongjiang1989 I was reading this post and their sample code they ran in the Go Playground. Could it be some TLS Cypher issue?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dongjiang1989, elihai-risk, enekui
Once this PR has been reviewed and has the lgtm label, please ask for approval from dgrisonnet. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@NahumLitvin
Copy link

trying again. can any1 resolve this or offer a workaround?

@dgrisonnet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2024
@dongjiang1989
update by codereview
3aecde0 
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2024
@dongjiang1989
Copy link
Author

Hi @dongjiang1989
Even after deploying a new docker image with your patch, I'm still getting the error message

E0729 22:37:58.058665       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.171.9:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-171-9.ec2.internal"
E0729 22:39:43.033961       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.174.222:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-174-222.ec2.internal"
E0729 22:39:58.162997       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.149.46:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-149-46.ec2.internal"
E0729 22:42:13.112497       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.242.20:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-242-20.ec2.internal"

kubernetes version and metrics-server verison?

Hi @dongjiang1989
Even after deploying a new docker image with your patch, I'm still getting the error message

E0729 22:37:58.058665       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.171.9:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-171-9.ec2.internal"
E0729 22:39:43.033961       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.174.222:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-174-222.ec2.internal"
E0729 22:39:58.162997       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.149.46:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-149-46.ec2.internal"
E0729 22:42:13.112497       1 scraper.go:149] "Failed to scrape node" err="Get \"https://172.60.242.20:10250/metrics/resource\": remote error: tls: internal error" node="ip-172-60-242-20.ec2.internal"

@marcelaraujo Please show your kubernetes version and metrics-server verison?

K8S: v1.29.4 Metrics-server: Latest + your patch

@dongjiang1989 I was reading this post and their sample code they ran in the Go Playground. Could it be some TLS Cypher issue?

@marcelaraujo Please re-check this patch
3aecde0

@dongjiang1989
Merge branch 'kubernetes-sigs:master' into fix-tlsconfig
367331f
@dongjiang1989
update kubelet_client
601521b 
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@dongjiang1989
fix unittest case
4b0bb66 
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@dongjiang1989
fix unittest case
b4d69e1 
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2024
@slashpai slashpai mentioned this pull request Sep 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enekui enekui enekui approved these changes

@elihai-risk elihai-risk elihai-risk approved these changes

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@yangjunmyfm192085 yangjunmyfm192085 Awaiting requested review from yangjunmyfm192085

Assignees

@dgrisonnet dgrisonnet

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to scrape node: remote error: tls: internal error
7 participants
@dongjiang1989 @k8s-ci-robot @dgrisonnet @NahumLitvin @marcelaraujo @enekui @elihai-risk