Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to go 1.21 #1368

Merged
merged 1 commit into from
Nov 13, 2023
Merged

chore: update to go 1.21 #1368

merged 1 commit into from
Nov 13, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 2, 2023

/kind feature

  • update to go 1.21

@aramase
chore: update to go 1.21
7cdb803 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2023
@k8s-ci-robot k8s-ci-robot requested review from nilekhc and tam7t November 2, 2023 23:02
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@aramase
Copy link
Member Author

aramase commented Nov 2, 2023

/assign @nilekhc
/cc @amitmodak

@k8s-ci-robot
Copy link
Contributor

@aramase: GitHub didn't allow me to request PR reviews from the following users: amitmodak.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @nilekhc
/cc @amitmodak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nilekhc
nilekhc reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@nilekhc nilekhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question. Otherwise LGTM.

Makefile Show resolved Hide resolved
@nilekhc
Copy link
Contributor

nilekhc commented Nov 13, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2e99322 into kubernetes-sigs:main Nov 13, 2023
7 checks passed
@aramase aramase deleted the aramase/c/go1.21 branch November 13, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilekhc nilekhc nilekhc left review comments

@tam7t tam7t Awaiting requested review from tam7t

Assignees

@nilekhc nilekhc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aramase @k8s-ci-robot @nilekhc