Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the v3-to-v4 doc to cover some changes that I missed #843

Merged
merged 2 commits into from
Nov 12, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions v3-to-v4.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,26 @@ and try to set `--ref` from them.
| other | other | "" | error |
|----------|---------|---------|------------------------------|

#### Default target

In git-sync v3, if neither `--branch` nor `--rev` were specified, the default
was to sync the HEAD of the branch named "master". Many git repos have changed
to "main" or something else as the default branch name, so git-sync v4 changes
the default target to be the HEAD of whatever the `--repo`'s default branch is.
If that default branch is not "master", then the default target will be
different in v4 than in v3.

#### Abbreviated hashes

Because of the fetch loop, git-sync v3 allowed a user to specify `--branch` and
`--rev`, where the rev was a shortened hash (aka SHA), which would be locally
expanded to the full hash. v4 tries hard not to pull extra stuff, which means
we don't have enough information locally to do that resolution, and there no
way to ask the server to do it for us (at least, not as far as we know).

The net result is that, when using a hash for `--ref`, it must be a full hash,
and not an abbreviated form.

### Log-related flags

git-sync v3 exposed a number of log-related flags (e.g. `-logtostderr`). These
Expand Down
Loading