Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the idea of "env-flags" #886

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Add the idea of "env-flags" #886

merged 2 commits into from
Jun 13, 2024

Commits on Jun 13, 2024

  1. Add the idea of "env-flags" 

    Env-flags are "flags" that can only be set by env var (see caveat below).
All of the real flags have a corresponding env-flag (kind of, but not
really).  The real goal was to deprecate `--password` but keep the env
var as a documented interface.

This does that (though --password still works) and updates the usage and
manual.

This allows some future work to follow the pattern.  We do not register
every CLI flag as an env-flag because the help text would be
duplicative.  This probably wants a wrapper API that allows declaring of
abstract flags, with CLI, env, or both sources.

Caveat:

ACTUALLY, these still have a flag, but the flag is specially named and
hidden.  This makes testing a little easier where passing flags is
handled well but env vars is not.
    @thockin
    thockin committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    945ce97 View commit details
    Browse the repository at this point in the history

  2. Add -? to manual

    @thockin
    thockin committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    90b76fb View commit details
    Browse the repository at this point in the history