Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_e2e.sh: Use index to expand FUNCNAME #901

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

rul
Copy link
Contributor

@rul rul commented Jun 22, 2024

Fixes SC2128. Part of #891.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 22, 2024
@thockin thockin added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 22, 2024
@thockin
Copy link
Member

thockin commented Jun 22, 2024

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rul, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit eab3f83 into kubernetes:master Jun 22, 2024
5 checks passed
@thockin
Copy link
Member

thockin commented Jun 22, 2024

You could make make of these same changes to test_git.sh, too :)

@rul
Copy link
Contributor Author

rul commented Jun 22, 2024

You could make make of these same changes to test_git.sh, too :)

Sounds good. Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants