Duplicate port definition in nlb-with-tls-termination/deploy.yaml ?

[Mahoney]

My k8s isn't very strong, is it a bug that there are two port 80s here? We get a duplicate port definition warning applying this manifest.

ingress-nginx/deploy/static/provider/aws/nlb-with-tls-termination/deploy.yaml

Lines 479 to 484 in 05eda3d

	- containerPort: 80
	name: http
	protocol: TCP
	- containerPort: 80
	name: https
	protocol: TCP

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[longwuyuan]

Where are you terminating TLS ?

[longwuyuan]

And no,its not a bug.

There will be more to understand depending on where you are terminating TLS

[longwuyuan]

/kind support

[Mahoney]

Where are you terminating TLS ?

At the NLB, hence using nlb-with-tls-termination/deploy.yaml.

[Mahoney]

And no,its not a bug.

There will be more to understand depending on where you are terminating TLS

OK, I was surprised when the output of applying that manifest via kubectl contained a warning about it.

I don't understand that it means for the specs.containers.ports array to contain the same containerPort twice with different names.

[longwuyuan]

Ah ok, idea is to send plaintext to controller as TLS terminated on NLB

…

On Sat, 12 Oct, 2024, 14:18 Robert Elliot, ***@***.***> wrote: And no,its not a bug. There will be more to understand depending on where you are terminating TLS OK, I was surprised when the output of applying that manifest via kubectl contained a warning about it. I don't understand that it means for the specs.containers.ports array to contain the same containerPort twice with different names. — Reply to this email directly, view it on GitHub <#12163 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWSWUYUYQ2HSMDANVNTZ3DO7FAVCNFSM6AAAAABPZGPUKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGQ3DENRSGY> . You are receiving this because you commented.Message ID: ***@***.***>

[Gacko]

Basically this should not be a bug, if you're working with named ports everywhere and therefore want to abstract the real port number from the rest of your implementation.

I assume that Kubernetes at some point started complaining about this even though there might be real use cases for it. So in the end it might be worth taking a look into the chart implementation and find a way to only have the port listed once in such cases, especially because it's port 80 being named https. 😅

[longwuyuan]

/close

Closing this issue as there is no action item on the project. If a action is determined, then please reopen the ticket and link the PR

[k8s-ci-robot]

@longwuyuan: Closing this issue.

In response to this:

/close

Closing this issue as there is no action item on the project. If a action is determined, then please reopen the ticket and link the PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.