-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse workflow CI #10826
Reuse workflow CI #10826
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f85ffc3
to
6903694
Compare
/hold |
3f30b81
to
b3fa15c
Compare
/hold cancel |
/hold I will add image building and push here as well |
fd9bcf9
to
08c4c50
Compare
@@ -86,7 +88,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
needs: changes | |||
if: | | |||
(needs.changes.outputs.go == 'true') || (needs.changes.outputs.charts == 'true') || ${{ inputs.run_e2e }} | |||
(needs.changes.outputs.go == 'true') || (needs.changes.outputs.charts == 'true') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inputs.run_e2e
is used to manually run the e2e test workflow. If we remove this condition, not all steps will be executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was triggering the test for anything. I would say that maybe for e2e just on those corner case, people can do a stupid change on .go files :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i use it for testing and would like to keep it, when CI is broken on branches its nice to be able to just run github action e2e.
08c4c50
to
cf59ac8
Compare
ede38ec
to
fc72ca2
Compare
/hold cancel |
@@ -1,17 +0,0 @@ | |||
timeout: 1200s | |||
options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought we were keeping the cloudbuilds and adding the GHA functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed just from this image, as it is a bit borked and the name from it is different from folder, etc etc
a2797fe
to
8cbbeba
Compare
8cbbeba
to
388fc74
Compare
/cherry-pick release-1.9 |
@strongjz: #10826 failed to apply on top of branch "release-1.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
We've been repeating some parts of CI A LOT. Instead, we can reuse some workflow parts (like e2e tests) and keep it simple when we want to change something on this workflow