Add a subscription to gs://kubernetes-ci-logs. #7370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
area/infra
ameukam
reviewed
Oct 7, 2024
There's an existing PubSub topic for GCS changes to gs://kubernetes-ci-logs (in k8s-infra-prow). Attempt to add a new subscription to this in kubernetes-public so Kettle can use updates from the new logs bucket. (Note: I don't have permissions to run terraform here, so I haven't verified that these additions are valid.)
michelle192837
force-pushed
the
migrate
branch
from
30b8ae3
to
8313027
Compare
|
/lgtm Remove the hold when you found someone to apply this. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@michelle192837 Looks like we need a schema for the topic: │ Error: Missing required argument
│
│ with google_pubsub_subscription.kettle_ci_logs_subscription,
│ on k8s-kettle.tf line 106, in resource "google_pubsub_subscription" "kettle_ci_logs_subscription":
│ 106: topic = data.google_pubsub_topic.kubernetes_ci_logs_topic.id
│
│ The argument "topic" is required, but no definition was found. |
ameukam
added a commit
to ameukam/k8s.io
that referenced
this pull request
Oct 10, 2024
Follow-up of: - kubernetes#7370 The id of the PubSub topic is required instead of the topic's name.
dims
reviewed
Oct 10, 2024
|
|
||
| resource "google_pubsub_subscription" "kettle_ci_logs_subscription" { | ||
| name = "k8s-infra-kettle" | ||
| topic = data.google_pubsub_topic.kubernetes_ci_logs_topic.name |
There was a problem hiding this comment.
should this be id instead of name?
topic = data.google_pubsub_topic.kubernetes_ci_logs_topic.id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an existing PubSub topic for GCS changes to gs://kubernetes-ci-logs (in k8s-infra-prow). Attempt to add a new subscription to this in kubernetes-public so Kettle can use updates from the new logs bucket.
(Note: I don't have permissions to run terraform here, so I haven't verified that these additions are valid.)
/hold
Don't submit until we verify this will do something with
terraform planRef kubernetes/test-infra#33381