Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm join: add support for dry-run #2505

Closed
neolit123 opened this issue Jun 9, 2021 · 4 comments · Fixed by kubernetes/kubernetes#103027
Closed

kubeadm join: add support for dry-run #2505

neolit123 opened this issue Jun 9, 2021 · 4 comments · Fixed by kubernetes/kubernetes#103027
Assignees
Labels
area/UX help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@neolit123
Copy link
Member

with some of the work around rootless control plane support:
#2473

we were reminded that kubeadm join does not support "dry-run".
given, "init" and "upgrade" support it, it feels like a feature gap that "join" does not.

the purpose of this issue is to track the addition of the dry-run feature to "join".

to implement it, we should follow the established pattern in kubeadm init, e.g. see:

https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/cmd/init.go:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/cmd/init.go#L95
https://github.com/kubernetes/kubernetes/blob/abac950cd72101b073e05250b99e3e3c2d067ef8/cmd/kubeadm/app/cmd/init.go#L329

and how initData.DryRun() it is used in phases under cmd/phases/init.

@neolit123 neolit123 changed the title kubeadm join does not support dry run kubeadm join: add support for dry-run Jun 9, 2021
@neolit123 neolit123 added area/UX kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jun 9, 2021
@neolit123 neolit123 modified the milestones: v1.23, v1.22 Jun 9, 2021
@neolit123
Copy link
Member Author

adding to 1.22 milestone if someone wants to take this.

@SataQiu
Copy link
Member

SataQiu commented Jun 10, 2021

Waiting for new contributors to pick this up :)
If no one claims it, I can help with this.

/cc

@Haleygo
Copy link

Haleygo commented Jun 11, 2021

/assign
I will work on it and try to pull a request in a few days :)

@Haleygo
Copy link

Haleygo commented Jun 21, 2021

@neolit123 @SataQiu Sorry for the long waiting, pr is ready now. Can you guys take a look, thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UX help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants