kubeadm join: add support for dry-run #2505
Labels
area/UX
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
kind/feature
Categorizes issue or PR as related to a new feature.
priority/backlog
Higher priority than priority/awaiting-more-evidence.
with some of the work around rootless control plane support:
#2473
we were reminded that kubeadm join does not support "dry-run".
given, "init" and "upgrade" support it, it feels like a feature gap that "join" does not.
the purpose of this issue is to track the addition of the dry-run feature to "join".
to implement it, we should follow the established pattern in kubeadm init, e.g. see:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/cmd/init.go:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/cmd/init.go#L95
https://github.com/kubernetes/kubernetes/blob/abac950cd72101b073e05250b99e3e3c2d067ef8/cmd/kubeadm/app/cmd/init.go#L329
and how initData.DryRun() it is used in phases under cmd/phases/init.
The text was updated successfully, but these errors were encountered: