Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag "--skip-addons" to kubeadm upgrade #2846

Closed
chenk008 opened this issue Mar 22, 2023 · 8 comments
Closed

Add flag "--skip-addons" to kubeadm upgrade #2846

chenk008 opened this issue Mar 22, 2023 · 8 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@chenk008
Copy link

What would you like to be added?

Add flag "--skip-addons" to kubeadm upgrade, these addons upgrades will be skipped

Why is this needed?

In some certain scenarios, cluster administrators want to skip addons(i.e. coredns,kube-proxy) upgrades. The addons upgrades may affect the data plane, so administrators must be more careful to upgrade these addons.

@chenk008 chenk008 added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

  • /sig <group-name>
  • /wg <group-name>
  • /committee <group-name>

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123
Copy link
Member

/transfer kubeadm

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes/kubernetes Mar 22, 2023
@neolit123
Copy link
Member

neolit123 commented Mar 22, 2023

kubeadm upgrade checks if the addon config maps are missing and then does not perform upgrade of the addons. but the FR here is different, perhaps in such a case admins should skip the addons on init and deploy them with custom names, so that they are not managed by kubeadm upgrade too.

i think ideally this skip should be possible with upgrade phases. we have a plan to add them but it's a bit complicated.

#1318

i am generally -1 to add this new flag, but let's see what others think.

@neolit123 neolit123 added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Mar 22, 2023
@neolit123
Copy link
Member

Add flag "--skip-addons" to kubeadm upgrade

the flag should be for 'upgrade apply'

@chenk008
Copy link
Author

@neolit123 kubeadm upgrade apply support --skip-phases option, it looks good to me.

@neolit123
Copy link
Member

ok, let's keep this planned for:
#1318

@W1zzardTPU
Copy link

W1zzardTPU commented Jan 19, 2024

kubeadm upgrade checks if the addon config maps are missing and then does not perform upgrade of the addons

Great tip! I ran into the same issue with coredns (which we manage separately through ArgoCD). During upgrade kubeadm insisted that it really wanted to change some immutable values in the coredns deployment, so it kept failing.

My workaround was to change the coredns configmap name to something other than "coredns", so kubeadm couldn't find it and skipped that phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

4 participants